Re: [PATCHv4] mtd: gpio-nand: add device tree bindings

[Jamie Iles <jamie-wmLquQDDieKakBO8gow8eQ@public.gmane.org>]

On Mon, Aug 15, 2011 at 04:57:56PM +0300, Artem Bityutskiy wrote:
> On Tue, 2011-08-09 at 16:12 +0100, Jamie Iles wrote:
> > +static int gpio_nand_of_get_options(struct device *dev,
> > +				    struct gpio_nand_platdata *plat)
> > +{
> > +	u32 width;
> > +
> > +	if (!of_property_read_u32(dev->of_node, "bank-width", &width)) {
> > +		if (width == 2) {
> > +			plat->options |= NAND_BUSWIDTH_16;
> > +		} else if (width != 1) {
> > +			dev_err(dev, "invalid bank-width %u\n", width);
> > +			return -EINVAL;
> > +		}
> > +	}
> > +
> > +	return 0;
> > +}
> > +
> > +static void gpio_nand_of_get_gpio(struct device *dev,
> > +				  struct gpio_nand_platdata *plat)
> > +{
> > +	plat->gpio_rdy = of_get_gpio(dev->of_node, 0);
> > +	plat->gpio_nce = of_get_gpio(dev->of_node, 1);
> > +	plat->gpio_ale = of_get_gpio(dev->of_node, 2);
> > +	plat->gpio_cle = of_get_gpio(dev->of_node, 3);
> > +	plat->gpio_nwp = of_get_gpio(dev->of_node, 4);
> > +}
> > +
> > +static void gpio_nand_of_get_chip_delay(struct device *dev,
> > +					struct gpio_nand_platdata *plat)
> > +{
> > +	u32 chip_delay;
> > +
> > +	if (!of_property_read_u32(dev->of_node, "chip-delay", &chip_delay))
> > +		plat->chip_delay = (int)chip_delay;
> > +}
> > +
> > +static int gpio_nand_of_get_config(struct device *dev,
> > +				   struct gpio_nand_platdata *plat)
> > +{
> > +	int ret = gpio_nand_of_get_options(dev, plat);
> > +
> > +	if (ret < 0)
> > +		return ret;
> > +
> > +	gpio_nand_of_get_gpio(dev, plat);
> > +	gpio_nand_of_get_chip_delay(dev, plat);
> > +
> > +	return 0;
> > +}
> 
> Do we really need to have 3 additional helper functions for
> 'gpio_nand_of_get_config()' ?

Not really, I'm happy to fold those all into one if you prefer.

Jamie