From: David Miller <davem@davemloft.net>
To: davidb@codeaurora.org
Cc: devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: of_iomap() matched with plan iounmap()
Date: Thu, 18 Aug 2011 20:34:47 -0700 (PDT) [thread overview]
Message-ID: <20110818.203447.462383652600224162.davem@davemloft.net> (raw)
In-Reply-To: <20110818170226.GA16721@huya.qualcomm.com>
From: David Brown <davidb@codeaurora.org>
Date: Thu, 18 Aug 2011 10:02:26 -0700
> The SPARC target contains of_ioremap() and of_iounmap(), which various
> drivers use (generally inside of CONFIG_SBUS).
>
> include/linux/of_address.h contains a definition for of_iomap(), but
> not corresponding unmap call. Code using this calls the regular
> iounmap().
>
> Is it safe to assume that of_iomap() will always be based on ioremap()
> and therefore it is safe to use iounmap(), or would it be better to
> define another name for drivers to use as the inverse of of_iomap().
> I'm not sure what to call it, since of_iounmap() is already taken by
> SPARC.
It's better to define a matching of_iounmap() interface, even if for
now it is exactly iounmap()
next prev parent reply other threads:[~2011-08-19 3:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-18 17:02 of_iomap() matched with plan iounmap() David Brown
2011-08-19 3:34 ` David Miller [this message]
2011-08-19 12:26 ` Arnd Bergmann
2011-08-19 13:26 ` David Miller
[not found] ` <20110819.062609.1865751197015675220.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2011-08-22 14:07 ` Arnd Bergmann
2011-08-22 18:47 ` David Miller
2011-08-19 21:19 ` David Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110818.203447.462383652600224162.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=davidb@codeaurora.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).