Re: [RFC] OMAP3+: boards: Fix the __initconst build error for devicetree/test branch

[Felipe Balbi <balbi@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1917 bytes --]

HI,

On Fri, Aug 19, 2011 at 04:24:00PM +0200, Cousson, Benoit wrote:
> Hi Grant,
> 
> The current devicetree/test branch is broken due to the introduction
> of the __initconst for dt_compat table.
> 
> My original basic fix is the following one, but Felipe figured out the
> root cause. So it can be fixed by adding an extra const to make the
> whole table const:
> -	const char		**dt_compat;	/* array of device tree
> +	const char		* const *dt_compat; /* array of device tree
> 
> That fix will require fixing all the current users of dt_compat with
> something like that:
> 
> -static const char *omap3_beagle_dt_match[] __initconst = {
> +static const char * const omap3_beagle_dt_match[] __initconst = {
> 
> A couple of of_XXX APIs will have to updated as well, that's why I was
> wondering if you wanted to go that way.
> 
> Any thought?

the funny thing is that this was not happening with CodeSourcery 2011.03
when I sent the patch.

Maybe it's either a compiler bug on one of the toolchains or newer GCCs
are smart enough to create another section ??

But then again, 2011.03 isn't compiling sleep34xx.S:

arch/arm/mach-omap2/sleep34xx.S: Assembler messages:
arch/arm/mach-omap2/sleep34xx.S:150: Error: selected processor does not support ARM mode `smc #1'
arch/arm/mach-omap2/sleep34xx.S:418: Error: selected processor does not support ARM mode `smc #1'
arch/arm/mach-omap2/sleep34xx.S:429: Error: selected processor does not support ARM mode `smc #1'
arch/arm/mach-omap2/sleep34xx.S:454: Error: selected processor does not support ARM mode `smc #0'
arch/arm/mach-omap2/sleep34xx.S:460: Error: selected processor does not support ARM mode `smc #0'
arch/arm/mach-omap2/sleep34xx.S:465: Error: selected processor does not support ARM mode `smc #0'
make[1]: *** [arch/arm/mach-omap2/sleep34xx.o] Error 1

so it might be better to keep 2010.09 working.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]