From: David Miller <davem@davemloft.net>
To: arnd@arndb.de
Cc: davidb@codeaurora.org, devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: of_iomap() matched with plan iounmap()
Date: Mon, 22 Aug 2011 11:47:43 -0700 (PDT) [thread overview]
Message-ID: <20110822.114743.2119393178497975105.davem@davemloft.net> (raw)
In-Reply-To: <201108221607.25179.arnd@arndb.de>
From: Arnd Bergmann <arnd@arndb.de>
Date: Mon, 22 Aug 2011 16:07:25 +0200
> How about renaming the sparc of_ioremap/of_iounmap pair to
> resource_iomap/resource_iounmap? I believe that it is not
> (any more) tied to device tree based probing at all, and also
> could be useful for other subsystems on non-sparc architectures.
Sure, but it would be even nicer if other platforms used pre-computed
resources :-)
It would make OF devices match how PCI devices are managed, and that's
one of the main reasons I implemented it this way.
I know someone is going to say that OF resource resolution is "hard" or
difficult to untangle with how drivers on other platforms work. But
that situation only exists because other platforms didn't do preresolved
OF resources from the beginning.
Having resource resolution handling and/or knowledge scattered throughout
all of the non-sparc OF drivers is very unwise.
next prev parent reply other threads:[~2011-08-22 18:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-18 17:02 of_iomap() matched with plan iounmap() David Brown
2011-08-19 3:34 ` David Miller
2011-08-19 12:26 ` Arnd Bergmann
2011-08-19 13:26 ` David Miller
[not found] ` <20110819.062609.1865751197015675220.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2011-08-22 14:07 ` Arnd Bergmann
2011-08-22 18:47 ` David Miller [this message]
2011-08-19 21:19 ` David Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110822.114743.2119393178497975105.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=davidb@codeaurora.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).