devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jamie Iles <jamie@jamieiles.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Jamie Iles <jamie@jamieiles.com>,
	linux-serial@vger.kernel.org,
	devicetree-discuss@lists.ozlabs.org,
	Alan Cox <alan@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH] tty: add a DesignWare 8250 driver
Date: Fri, 26 Aug 2011 17:20:21 +0100	[thread overview]
Message-ID: <20110826162021.GC2802@pulham.picochip.com> (raw)
In-Reply-To: <201108261804.02784.arnd@arndb.de>

On Fri, Aug 26, 2011 at 06:04:02PM +0200, Arnd Bergmann wrote:
> On Friday 26 August 2011, Jamie Iles wrote:
> > The Synopsys DesignWare 8250 is an 8250 that has an extra interrupt that
> > gets raised when writing to the LCR when busy.  To handle this we need
> > special serial_out, serial_in and handle_irq methods.  Add a new
> > platform driver that uses these accessors.
> > 
> > Cc: Alan Cox <alan@linux.intel.com>
> > Cc: Greg Kroah-Hartman <gregkh@suse.de>
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > Signed-off-by: Jamie Iles <jamie@jamieiles.com>
> 
> The driver looks good to me,
> 
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> 
> Is the patch to export serial8250_handle_irq already in Greg's tree or is that
> still missing?

No, and I really don't know how I missed it.  I was sure an allmodconfig 
build worked, but perhaps 8250_dw wasn't selected.  Anyhow, here's the 
patch that does that.

Apologies again for making such a mess out of this series!

Thanks,

Jamie

8<---

From: Jamie Iles <jamie@jamieiles.com>
Subject: [PATCH] tty: 8250: export serial8250_handle_irq

Allow modules to use the normal 8250 irq handler inside their own.

Signed-off-by: Jamie Iles <jamie@jamieiles.com>
---
 drivers/tty/serial/8250.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/tty/serial/8250.c b/drivers/tty/serial/8250.c
index 6f594d2..435ce14 100644
--- a/drivers/tty/serial/8250.c
+++ b/drivers/tty/serial/8250.c
@@ -1588,6 +1588,7 @@ int serial8250_handle_irq(struct uart_port *port, unsigned int iir)
 
 	return 0;
 }
+EXPORT_SYMBOL_GPL(serial8250_handle_irq);
 
 static int serial8250_default_handle_irq(struct uart_port *port)
 {
-- 
1.7.4.1


  reply	other threads:[~2011-08-26 16:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-26 14:28 [PATCH] tty: add a DesignWare 8250 driver Jamie Iles
2011-08-26 16:04 ` Arnd Bergmann
2011-08-26 16:20   ` Jamie Iles [this message]
2011-08-26 17:57     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110826162021.GC2802@pulham.picochip.com \
    --to=jamie@jamieiles.com \
    --cc=alan@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=gregkh@suse.de \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).