From: Greg KH <greg@kroah.com>
To: Jamie Iles <jamie@jamieiles.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-serial@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org,
Alan Cox <alan@linux.intel.com>,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH] tty: add a DesignWare 8250 driver
Date: Fri, 26 Aug 2011 10:57:11 -0700 [thread overview]
Message-ID: <20110826175711.GA15324@kroah.com> (raw)
In-Reply-To: <20110826162021.GC2802@pulham.picochip.com>
On Fri, Aug 26, 2011 at 05:20:21PM +0100, Jamie Iles wrote:
> On Fri, Aug 26, 2011 at 06:04:02PM +0200, Arnd Bergmann wrote:
> > On Friday 26 August 2011, Jamie Iles wrote:
> > > The Synopsys DesignWare 8250 is an 8250 that has an extra interrupt that
> > > gets raised when writing to the LCR when busy. To handle this we need
> > > special serial_out, serial_in and handle_irq methods. Add a new
> > > platform driver that uses these accessors.
> > >
> > > Cc: Alan Cox <alan@linux.intel.com>
> > > Cc: Greg Kroah-Hartman <gregkh@suse.de>
> > > Cc: Arnd Bergmann <arnd@arndb.de>
> > > Signed-off-by: Jamie Iles <jamie@jamieiles.com>
> >
> > The driver looks good to me,
> >
> > Acked-by: Arnd Bergmann <arnd@arndb.de>
> >
> > Is the patch to export serial8250_handle_irq already in Greg's tree or is that
> > still missing?
>
> No, and I really don't know how I missed it. I was sure an allmodconfig
> build worked, but perhaps 8250_dw wasn't selected. Anyhow, here's the
> patch that does that.
>
> Apologies again for making such a mess out of this series!
>
> Thanks,
>
> Jamie
>
> 8<---
>
> From: Jamie Iles <jamie@jamieiles.com>
> Subject: [PATCH] tty: 8250: export serial8250_handle_irq
>
> Allow modules to use the normal 8250 irq handler inside their own.
So this patch needs to be applied before the first one here, right?
Care to just resend the patches again, in the right order, so I am sure
to get it correct?
confused,
greg k-h
prev parent reply other threads:[~2011-08-26 17:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-26 14:28 [PATCH] tty: add a DesignWare 8250 driver Jamie Iles
2011-08-26 16:04 ` Arnd Bergmann
2011-08-26 16:20 ` Jamie Iles
2011-08-26 17:57 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110826175711.GA15324@kroah.com \
--to=greg@kroah.com \
--cc=alan@linux.intel.com \
--cc=arnd@arndb.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=gregkh@suse.de \
--cc=jamie@jamieiles.com \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).