From: Shawn Guo <shawn.guo@freescale.com>
To: Stephen Warren <swarren@nvidia.com>
Cc: devicetree-discuss@lists.ozlabs.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Grant Likely <grant.likely@secretlab.ca>,
linux-tegra@vger.kernel.org, Chris Ball <cjb@laptop.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] sdhci/tegra: Add Device Tree probing support
Date: Tue, 30 Aug 2011 11:40:36 +0800 [thread overview]
Message-ID: <20110830034035.GC19294@S2100-06.ap.freescale.net> (raw)
In-Reply-To: <1314123334-23133-1-git-send-email-swarren@nvidia.com>
On Tue, Aug 23, 2011 at 12:15:33PM -0600, Stephen Warren wrote:
> From: Grant Likely <grant.likely@secretlab.ca>
>
> Add hooks to read gpio configuration out of the device tree node.
>
> [grant.likely: Rewrite of original patch from John Bonesio]
> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> [swarren: Fixed tegra_sdhci_get_ro() to retrieve pdata correctly]
> [swarren: Reworked to avoid #ifdef CONFIG_OF]
> [swarren: Reworked binding based on fsl-imx-esdhc.txt]
> [swarren: Documented binding]
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> Theoretically, these two patches should be merged in order in one place,
> since the 2nd logically depends on the first. However, it's really just
> a documentation dependency, so I think it's fine to merge them into the
> MMC and DT trees separately and let them meet in linux-next.
>
> .../devicetree/bindings/mmc/nvidia-sdhci.txt | 25 ++++++++++
> drivers/mmc/host/sdhci-tegra.c | 51 +++++++++++++++----
> 2 files changed, 65 insertions(+), 11 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/mmc/nvidia-sdhci.txt
>
> diff --git a/Documentation/devicetree/bindings/mmc/nvidia-sdhci.txt b/Documentation/devicetree/bindings/mmc/nvidia-sdhci.txt
> new file mode 100644
> index 0000000..c87f667
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/nvidia-sdhci.txt
> @@ -0,0 +1,25 @@
> +* NVIDIA Tegra Secure Digital Host Controller
> +
> +This controller on Tegra family SoCs provides an interface for MMC, SD,
> +and SDIO types of memory cards.
> +
> +Required properties:
> +- compatible : Should be "nvidia,<chip>-sdhci"
> +- reg : Should contain eSDHC registers location and length
> +- interrupts : Should contain eSDHC interrupt
You may want to replace eSDHC with something Tegra specific.
--
Regards,
Shawn
next prev parent reply other threads:[~2011-08-30 3:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-23 18:15 [PATCH 1/2] sdhci/tegra: Add Device Tree probing support Stephen Warren
[not found] ` <1314123334-23133-1-git-send-email-swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-08-23 18:15 ` [PATCH 2/2] arm/dt: Tegra: Update SDHCI nodes to match bindings Stephen Warren
[not found] ` <1314123334-23133-2-git-send-email-swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-08-26 5:19 ` Olof Johansson
2011-08-26 5:19 ` [PATCH 1/2] sdhci/tegra: Add Device Tree probing support Olof Johansson
2011-08-30 7:52 ` Marc Dietich
[not found] ` <201108300952.02418.marvin24-Mmb7MZpHnFY@public.gmane.org>
2011-08-30 16:17 ` Stephen Warren
2011-08-23 18:41 ` Chris Ball
2011-08-30 3:40 ` Shawn Guo [this message]
2011-08-30 16:01 ` Stephen Warren
2011-08-31 2:49 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110830034035.GC19294@S2100-06.ap.freescale.net \
--to=shawn.guo@freescale.com \
--cc=cjb@laptop.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).