From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [RFC PATCH 04/11] omap4: SDP: Pass regulator_init_data from DT Date: Thu, 15 Sep 2011 16:15:44 -0600 Message-ID: <20110915221544.GL3523@ponder.secretlab.ca> References: <1316085727-15023-1-git-send-email-rnayak@ti.com> <1316085727-15023-2-git-send-email-rnayak@ti.com> <1316085727-15023-3-git-send-email-rnayak@ti.com> <1316085727-15023-4-git-send-email-rnayak@ti.com> <1316085727-15023-5-git-send-email-rnayak@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1316085727-15023-5-git-send-email-rnayak@ti.com> Sender: linux-omap-owner@vger.kernel.org To: Rajendra Nayak Cc: broonie@opensource.wolfsonmicro.com, devicetree-discuss@lists.ozlabs.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tony@atomide.com, lrg@ti.com, b-cousson@ti.com List-Id: devicetree@vger.kernel.org On Thu, Sep 15, 2011 at 04:52:00PM +0530, Rajendra Nayak wrote: > Pass regulator_init_data information for omap4sdp from device tree so the > regulator driver can then use the regulator helper > routine to extract and use them during the driver probe(). > > Add documentation for TWL regulator specific bindings. > > Signed-off-by: Rajendra Nayak > --- > .../bindings/regulator/twl-regulator.txt | 18 ++++++++++++++++++ > arch/arm/boot/dts/omap4-sdp.dts | 16 ++++++++++++++++ > 2 files changed, 34 insertions(+), 0 deletions(-) > create mode 100644 Documentation/devicetree/bindings/regulator/twl-regulator.txt > > diff --git a/Documentation/devicetree/bindings/regulator/twl-regulator.txt b/Documentation/devicetree/bindings/regulator/twl-regulator.txt > new file mode 100644 > index 0000000..59df44b > --- /dev/null > +++ b/Documentation/devicetree/bindings/regulator/twl-regulator.txt > @@ -0,0 +1,18 @@ > +TWL family of regulators > + > +Required properties: > +- compatible: Must be "regulator","ti,twl-reg"; Most specific values always come first. Of course, this point is moot since "regulator" shouldn't be used at all. > + > +Optional properties: > +- Any optional property defined in bindings/regulator/regulator.txt > +- ti,reg-id: Identifier for a TWL regulator, defined in linux/i2c/twl.h file. This needs more explanation. I don't understand what it means. > + > +Example: > + > + xyz-regulator: regulator@0 { > + compatible = "regulator","ti,twl-reg"; > + ti,reg-id = <37>; /* TWL6030_REG_VAUX1_6030 */ > + min-uV = <1000000>; > + max-uV = <3000000>; > + apply-uV; > + }; > diff --git a/arch/arm/boot/dts/omap4-sdp.dts b/arch/arm/boot/dts/omap4-sdp.dts > index 14faf92..2a613e2 100644 > --- a/arch/arm/boot/dts/omap4-sdp.dts > +++ b/arch/arm/boot/dts/omap4-sdp.dts > @@ -52,6 +52,22 @@ > interrupts = <11>; > reg = <0>; > }; > + > + vaux1-regulator: regulator@0 { > + compatible = "regulator","ti,twl-reg"; > + ti,reg-id = <37>; /* TWL6030_REG_VAUX1_6030 */ > + min-uV = <1000000>; > + max-uV = <3000000>; > + apply-uV; > + }; > + > + vusim-regulator: regulator@1 { > + compatible = "regulator","ti,twl-reg"; > + ti,reg-id = <42>; /* TWL6030_REG_VUSIM */ > + min-uV = <1200000>; > + max-uV = <2900000>; > + apply_uV; > + }; > }; > }; > > -- > 1.7.1 >