From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH] pata-generic/of: Make probing via device tree non-powerpc-specific Date: Fri, 16 Sep 2011 22:43:13 +0100 Message-ID: <20110916214313.GB16381@n2100.arm.linux.org.uk> References: <1316183890-13677-1-git-send-email-dave.martin@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1316183890-13677-1-git-send-email-dave.martin@linaro.org> Sender: linux-ide-owner@vger.kernel.org To: Dave Martin Cc: devicetree-discuss@lists.ozlabs.org, Grant Likely , linux-ide@vger.kernel.org, Jeff Garzik , linux-arm-kernel@lists.infradead.org, patches@linaro.org List-Id: devicetree@vger.kernel.org On Fri, Sep 16, 2011 at 03:38:10PM +0100, Dave Martin wrote: > This patch enables device-tree-based probing of the pata-generic > platform driver across all architectures: > > * make the pata_of_generic module depend on OF instead of PPC_OF; > * supply some missing inclues; > * replace endianness-sensitive raw access to device tree data > with of_property_read_u32() calls. > > Signed-off-by: Dave Martin > --- > > Tested on ARM Versatile Express, with my soon-to-be-posted device > tree support patches. This may not be the correct way to support the CF slot on Versatile Express - it depends whether the CF slot on VE supports just CF memory cards or whether it can take any CF card. If the latter, then what may be inserted could be a CF network card, and that means it's probably wrong to tell the kernel that what's there is a PATA interface.