From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: Devicetree Discuss
<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>
Subject: Re: [RESEND PATCH v3 3/7] Add utilfdt tests
Date: Tue, 20 Sep 2011 11:11:47 +1000 [thread overview]
Message-ID: <20110920011147.GF29197@yookeroo.fritz.box> (raw)
In-Reply-To: <1316463668-976-4-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
On Mon, Sep 19, 2011 at 01:21:04PM -0700, Simon Glass wrote:
> This adds a few tests for the simple type argument supported by
> utilfdt_decode_type.
>
> I assume this will be squashed in with utilfdt, but I have left it out
> for easier review here.
Yes, it should be squashed in. Fwiw, in my experience, folding the
tests in from day 1 does not significantly impair review, since the
tests patch usually touches essentially disjoint files from the rest.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2011-09-20 1:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-19 20:21 [RESEND PATCH v3 0/7] Add fdtget and fdtput for access to fdt from build system Simon Glass
[not found] ` <1316463668-976-1-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2011-09-19 20:21 ` [RESEND PATCH v3 1/7] Create Makefile.utils and move ftdump into it Simon Glass
[not found] ` <1316463668-976-2-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2011-09-20 1:02 ` David Gibson
2011-09-19 20:21 ` [RESEND PATCH v3 2/7] Add utilfdt for common functions Simon Glass
[not found] ` <1316463668-976-3-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2011-09-20 1:08 ` David Gibson
[not found] ` <20110920010859.GE29197-787xzQ0H9iQXU02nzanrWNbf9cGiqdzd@public.gmane.org>
2011-09-20 3:54 ` Simon Glass
[not found] ` <CAPnjgZ0U_gYkQQR14UNZ0tAOT8jYxzwi_mEYXsT134m14m=8Bg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-09-20 8:12 ` David Gibson
2011-09-19 20:21 ` [RESEND PATCH v3 3/7] Add utilfdt tests Simon Glass
[not found] ` <1316463668-976-4-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2011-09-20 1:11 ` David Gibson [this message]
[not found] ` <20110920011147.GF29197-787xzQ0H9iQXU02nzanrWNbf9cGiqdzd@public.gmane.org>
2011-09-21 20:28 ` Simon Glass
2011-09-19 20:21 ` [RESEND PATCH v3 4/7] Make testutils use utilfdt Simon Glass
2011-09-19 20:21 ` [RESEND PATCH v3 5/7] ftdump: use utilfdt to read blob Simon Glass
2011-09-19 20:21 ` [RESEND PATCH v3 6/7] Add fdtget utility to read property values from a device tree Simon Glass
2011-09-19 20:21 ` [RESEND PATCH v3 7/7] Add fdtput utility to write property values to " Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110920011147.GF29197@yookeroo.fritz.box \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).