From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson Subject: Re: [RESEND PATCH v3 3/7] Add utilfdt tests Date: Tue, 20 Sep 2011 11:11:47 +1000 Message-ID: <20110920011147.GF29197@yookeroo.fritz.box> References: <1316463668-976-1-git-send-email-sjg@chromium.org> <1316463668-976-4-git-send-email-sjg@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1316463668-976-4-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Simon Glass Cc: Devicetree Discuss List-Id: devicetree@vger.kernel.org On Mon, Sep 19, 2011 at 01:21:04PM -0700, Simon Glass wrote: > This adds a few tests for the simple type argument supported by > utilfdt_decode_type. > > I assume this will be squashed in with utilfdt, but I have left it out > for easier review here. Yes, it should be squashed in. Fwiw, in my experience, folding the tests in from day 1 does not significantly impair review, since the tests patch usually touches essentially disjoint files from the rest. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson