From: David Miller <davem@davemloft.net>
To: dave.martin@linaro.org
Cc: netdev@vger.kernel.org, patches@linaro.org,
steve.glendinning@smsc.com, shawn.guo@linaro.org,
devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH] net/smsc911x: Correctly configure 16-bit register access from DT
Date: Wed, 21 Sep 2011 15:18:59 -0400 (EDT) [thread overview]
Message-ID: <20110921.151859.1493899537665203423.davem@davemloft.net> (raw)
In-Reply-To: <1315910969-4018-1-git-send-email-dave.martin@linaro.org>
From: Dave Martin <dave.martin@linaro.org>
Date: Tue, 13 Sep 2011 11:49:29 +0100
> The SMSC911X_USE_16BIT needs to be set when using 16-bit register
> access. However, currently no flag is set if the device tree
> doesn't specify 32-bit access, resulting in a BUG() and a non-
> working driver when 16-bit register access is configured for
> smsc911x in the DT.
>
> This patch should set the SMSC911X_USE_16BIT flag in a manner
> consistent with the documented DT bindings.
>
> Signed-off-by: Dave Martin <dave.martin@linaro.org>
Applied to net-next, thanks.
prev parent reply other threads:[~2011-09-21 19:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-13 10:49 [PATCH] net/smsc911x: Correctly configure 16-bit register access from DT Dave Martin
[not found] ` <1315910969-4018-1-git-send-email-dave.martin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-09-14 16:12 ` Grant Likely
2011-09-21 19:18 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110921.151859.1493899537665203423.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dave.martin@linaro.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=patches@linaro.org \
--cc=shawn.guo@linaro.org \
--cc=steve.glendinning@smsc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).