From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH 3/3] gpio-vx855: Add device tree binding Date: Wed, 21 Sep 2011 10:29:06 -0600 Message-ID: <20110921162906.GY7781@ponder.secretlab.ca> References: <20110921120214.DFDC79D401E@zog.reactivated.net> <20110921125051.GB25620@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20110921125051.GB25620-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Mark Brown Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, dilinger-pFFUokh25LWsTnJN9+BGXg@public.gmane.org, Daniel Drake , sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org List-Id: devicetree@vger.kernel.org On Wed, Sep 21, 2011 at 01:50:52PM +0100, Mark Brown wrote: > On Wed, Sep 21, 2011 at 01:02:14PM +0100, Daniel Drake wrote: > > > +- #gpio-cells : Should be two. The first cell is the pin number and the > > + second cell is used to specify optional parameters: > > + - bit 0 specifies polarity (0 for normal, 1 for inverted) > > Shouldn't we just have a property for the polarity? A flags cell in gpio specifiers (and irq specifiers for that matter) is well established practice. g.