From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH v2 RESEND 2] gpio-vx855: add device tree binding Date: Thu, 22 Sep 2011 11:41:36 -0600 Message-ID: <20110922174136.GP17168@ponder.secretlab.ca> References: <20110916181220.E12109D401C@zog.reactivated.net> <20110917155615.GT3523@ponder.secretlab.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Daniel Drake Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Mon, Sep 19, 2011 at 10:27:07AM +0100, Daniel Drake wrote: > Hi Grant, > > Thanks for looking at this. > > On Sat, Sep 17, 2011 at 4:56 PM, Grant Likely wrote: > > drivers/mfd/vx855.c should be modified to assign pdev->of_node, which > > can be used here for setting up c->of_node. > > There doesn't seem to be any obvious place in mfd/vx855.c to insert > this. All the platform device creation and addition is done inside the > mfd layer (e.g. mfd_add_device()). Should I look at extending the MFD > API to allow for of_nodes to be passed in? yes. g.