From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Anton Staaf <robotboy-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [PATCH 3/3] dtc: Add support for variable sized cells
Date: Fri, 23 Sep 2011 10:14:53 +1000 [thread overview]
Message-ID: <20110923001453.GB12286@yookeroo.fritz.box> (raw)
In-Reply-To: <CAF6FioV55CX9wBo5d1nKV=_t4+6BtHS6_hays08ZVgs2eDFvtA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Thu, Sep 22, 2011 at 11:02:59AM -0700, Anton Staaf wrote:
> On Wed, Sep 21, 2011 at 7:42 PM, David Gibson
> <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org> wrote:
> > On Wed, Sep 21, 2011 at 01:42:11PM -0700, Anton Staaf wrote:
> >> Cells of size 8, 16, 32, and 64 bits are supported. The new
> >> /size/ syntax was selected so as to not pollute the reserved
> >> keyword space with uint8/uint16/... type names.
> >>
> >> With this patch the following property assignment:
> >>
> >> property = /size/ 16 <0x1234 0x5678 0x0 0xffff>;
> >
> > I'm now thinking that just plain "/size/" is maybe a bit too generic
> > for this keyword. But I'm not sure what would be better. Maybe
> > /cellsize/ or /intsize/ or /arraysize/.
>
> Also /bits/ or /cellbits/ might make good choices because the size is in
> bits and not in bytes.
True; they are better ideas.
> I'm not fond of /arraysize/ because we are
> specifying the size of each element in the array, not the array
> itself.
Yeah, good point.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2011-09-23 0:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-21 20:42 [PATCH 0/3] Variable sized cell support Anton Staaf
[not found] ` <1316637731-21872-1-git-send-email-robotboy-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2011-09-21 20:42 ` [PATCH 1/3] libfdt: Add fdt16_to_cpu utility function Anton Staaf
[not found] ` <1316637731-21872-2-git-send-email-robotboy-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2011-09-22 2:25 ` David Gibson
2011-09-21 20:42 ` [PATCH 2/3] dtc: Add data_append_literal function Anton Staaf
[not found] ` <1316637731-21872-3-git-send-email-robotboy-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2011-09-22 2:33 ` David Gibson
[not found] ` <20110922023328.GF22223-787xzQ0H9iQXU02nzanrWNbf9cGiqdzd@public.gmane.org>
2011-09-22 17:57 ` Anton Staaf
[not found] ` <CAF6FioWE+ybLhXmfw8OUMTXiJ3Hi-ErDai_J63trcahSwSLOag-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-09-23 0:13 ` David Gibson
[not found] ` <20110923001345.GA12286-787xzQ0H9iQXU02nzanrWNbf9cGiqdzd@public.gmane.org>
2011-09-23 3:25 ` Anton Staaf
[not found] ` <CAF6FioXEh+nACgBV924cPf+MoHUpYdazG8n=JG5dmqSgUu84hg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-09-23 17:02 ` Anton Staaf
2011-09-21 20:42 ` [PATCH 3/3] dtc: Add support for variable sized cells Anton Staaf
[not found] ` <1316637731-21872-4-git-send-email-robotboy-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2011-09-22 2:42 ` David Gibson
[not found] ` <20110922024255.GG22223-787xzQ0H9iQXU02nzanrWNbf9cGiqdzd@public.gmane.org>
2011-09-22 18:02 ` Anton Staaf
[not found] ` <CAF6FioV55CX9wBo5d1nKV=_t4+6BtHS6_hays08ZVgs2eDFvtA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-09-23 0:14 ` David Gibson [this message]
2011-09-22 2:26 ` [PATCH 0/3] Variable sized cell support David Gibson
[not found] ` <20110922022634.GE22223-787xzQ0H9iQXU02nzanrWNbf9cGiqdzd@public.gmane.org>
2011-09-22 17:54 ` Anton Staaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110923001453.GB12286@yookeroo.fritz.box \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=robotboy-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).