From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 1/3] mfd: allow mfd_cell association with device tree node Date: Tue, 27 Sep 2011 19:38:32 +0100 Message-ID: <20110927183832.GS4289@opensource.wolfsonmicro.com> References: <20110921124936.GA25620@sirena.org.uk> <20110921131637.GF4374@opensource.wolfsonmicro.com> <20110927150555.GF20588@ponder.secretlab.ca> <20110927181420.GQ4289@opensource.wolfsonmicro.com> <20110927182636.GR4289@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Daniel Drake Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, dilinger-pFFUokh25LWsTnJN9+BGXg@public.gmane.org, sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Tue, Sep 27, 2011 at 07:28:40PM +0100, Daniel Drake wrote: > On Tue, Sep 27, 2011 at 7:26 PM, Mark Brown > > That seems like a bug that just happened to get noticed while reviewing > > this change, though... > Sorry if I'm missing something obvious but I'm not seeing the issue. > What exactly is this bug and what effects could it cause? You're modifying global data which should really be const and is shared between multiple devices in place. Probably you'll not notice any practical effects, especially if you don't happen to have multiple devices in the same system.