devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
To: Daniel Drake <dsd-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	dilinger-pFFUokh25LWsTnJN9+BGXg@public.gmane.org,
	sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/3] mfd: allow mfd_cell association with device tree node
Date: Mon, 3 Oct 2011 13:40:44 +0100	[thread overview]
Message-ID: <20111003124044.GF3731@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAMLZHHS+fFzuWtwOwt-g2y38g93uaZFyUGsooZyYLMT=mdWQFQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On Mon, Oct 03, 2011 at 01:30:15PM +0100, Daniel Drake wrote:
> On Mon, Oct 3, 2011 at 1:16 PM, Mark Brown

> > It seems to me like either the IP block is heavily dependant on the core
> > and shouldn't be split out in the device tree at all (but should instead
> > be part of the core node) or the IP block is very isolated from the core
> > (in which case we should just be able to instantiate the device from the
> > device tree without using explict code in the core driver).

> > This all feels like there's some abstraction violation going on.

> I guess it is a matter of opinion. To me, the abstraction is sensible
> and representative of the hardware.

> This also matches the way that the hardware is described by VIA in the
> specs, and it matches the way that Linux has its own device hierachy
> laid out (i.e. the ISA bridge driven by the mfd driver, which then
> spawns off a child device for the GPIO controller).

> It would not be possible to fold all of the isa bridge child
> components into the same device tree node without dealing with various
> namespace collisions.

So, I made two suggestions above and it sounds like you want the second
one but you've only responded to the first one without commenting on the
second.  My second suggestion was that if the block is sufficiently
isoltated from the core we should be able instantiate it from the device
tree without requiring explicit code in the core driver.

  parent reply	other threads:[~2011-10-03 12:40 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-21 12:01 [PATCH 1/3] mfd: allow mfd_cell association with device tree node Daniel Drake
     [not found] ` <20110921120148.4A81E9D401D-k/4jFdqg8LLlyo9zxV8I99HuzzzSOjJt@public.gmane.org>
2011-09-21 12:49   ` Mark Brown
     [not found]     ` <20110921124936.GA25620-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2011-09-21 13:02       ` Daniel Drake
2011-09-21 13:16         ` Mark Brown
2011-09-27 14:44           ` Daniel Drake
2011-09-27 15:05             ` Grant Likely
2011-09-27 15:18               ` Mark Brown
2011-09-27 16:44               ` Daniel Drake
2011-09-27 18:14                 ` Mark Brown
2011-09-27 18:25                   ` Daniel Drake
     [not found]                     ` <CAMLZHHSuoeAJ-AC9daxb83+EANV=YGK-aiYpQ_j2wFiyQa5ytw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-09-27 18:26                       ` Mark Brown
     [not found]                         ` <20110927182636.GR4289-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2011-09-27 18:28                           ` Daniel Drake
     [not found]                             ` <CAMLZHHR0rMZct2E91X8k+Lhv_y-pY_5+vshZw6dj194o9vSCJQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-09-27 18:38                               ` Mark Brown
2011-09-28  9:07                                 ` Daniel Drake
2011-09-28 12:31                                   ` Mark Brown
2011-10-03  8:40                                     ` Daniel Drake
2011-10-03 10:28                                       ` Mark Brown
     [not found]                                         ` <20111003102846.GA23811-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2011-10-03 10:39                                           ` Daniel Drake
2011-10-03 12:16                                             ` Mark Brown
     [not found]                                               ` <20111003121655.GB3731-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2011-10-03 12:30                                                 ` Daniel Drake
     [not found]                                                   ` <CAMLZHHS+fFzuWtwOwt-g2y38g93uaZFyUGsooZyYLMT=mdWQFQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-10-03 12:40                                                     ` Mark Brown [this message]
     [not found]                                                       ` <20111003124044.GF3731-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2011-10-03 12:53                                                         ` Daniel Drake
  -- strict thread matches above, loose matches on Subject: below --
2011-09-21 12:01 Daniel Drake
2011-09-28  9:08 Daniel Drake
2011-09-28  9:08 Daniel Drake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111003124044.GF3731@opensource.wolfsonmicro.com \
    --to=broonie-yzvpicuk2aatku/dhu1wvuem+bqzidxxqq4iyu8u01e@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=dilinger-pFFUokh25LWsTnJN9+BGXg@public.gmane.org \
    --cc=dsd-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).