From: Grant Likely <grant.likely@secretlab.ca>
To: Kyle Moffett <Kyle.D.Moffett@boeing.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org
Subject: Re: [RFC PATCH 02/17] of_mdio: Don't phy_scan_fixups() twice
Date: Tue, 25 Oct 2011 06:56:02 +0200 [thread overview]
Message-ID: <20111025045602.GB798@ponder.secretlab.ca> (raw)
In-Reply-To: <1319144425-15547-3-git-send-email-Kyle.D.Moffett@boeing.com>
On Thu, Oct 20, 2011 at 05:00:09PM -0400, Kyle Moffett wrote:
> The "phy_device_register()" call 5 lines down already calls
> phy_scan_fixups(), there's no need to do it a second time.
>
> Signed-off-by: Kyle Moffett <Kyle.D.Moffett@boeing.com>
Applied, thanks.
g.
> ---
> drivers/of/of_mdio.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
> index d35e300..980c079 100644
> --- a/drivers/of/of_mdio.c
> +++ b/drivers/of/of_mdio.c
> @@ -83,7 +83,6 @@ int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np)
> addr);
> continue;
> }
> - phy_scan_fixups(phy);
>
> /* Associate the OF node with the device structure so it
> * can be looked up later */
> --
> 1.7.2.5
>
prev parent reply other threads:[~2011-10-25 4:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1319144425-15547-1-git-send-email-Kyle.D.Moffett@boeing.com>
2011-10-20 21:00 ` [RFC PATCH 02/17] of_mdio: Don't phy_scan_fixups() twice Kyle Moffett
2011-10-25 4:56 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111025045602.GB798@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=Kyle.D.Moffett@boeing.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).