* [RFC PATCH 02/17] of_mdio: Don't phy_scan_fixups() twice [not found] <1319144425-15547-1-git-send-email-Kyle.D.Moffett@boeing.com> @ 2011-10-20 21:00 ` Kyle Moffett 2011-10-25 4:56 ` Grant Likely 0 siblings, 1 reply; 2+ messages in thread From: Kyle Moffett @ 2011-10-20 21:00 UTC (permalink / raw) To: linux-kernel, netdev; +Cc: Kyle Moffett, Grant Likely, devicetree-discuss The "phy_device_register()" call 5 lines down already calls phy_scan_fixups(), there's no need to do it a second time. Signed-off-by: Kyle Moffett <Kyle.D.Moffett@boeing.com> --- drivers/of/of_mdio.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c index d35e300..980c079 100644 --- a/drivers/of/of_mdio.c +++ b/drivers/of/of_mdio.c @@ -83,7 +83,6 @@ int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np) addr); continue; } - phy_scan_fixups(phy); /* Associate the OF node with the device structure so it * can be looked up later */ -- 1.7.2.5 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RFC PATCH 02/17] of_mdio: Don't phy_scan_fixups() twice 2011-10-20 21:00 ` [RFC PATCH 02/17] of_mdio: Don't phy_scan_fixups() twice Kyle Moffett @ 2011-10-25 4:56 ` Grant Likely 0 siblings, 0 replies; 2+ messages in thread From: Grant Likely @ 2011-10-25 4:56 UTC (permalink / raw) To: Kyle Moffett; +Cc: linux-kernel, netdev, devicetree-discuss On Thu, Oct 20, 2011 at 05:00:09PM -0400, Kyle Moffett wrote: > The "phy_device_register()" call 5 lines down already calls > phy_scan_fixups(), there's no need to do it a second time. > > Signed-off-by: Kyle Moffett <Kyle.D.Moffett@boeing.com> Applied, thanks. g. > --- > drivers/of/of_mdio.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c > index d35e300..980c079 100644 > --- a/drivers/of/of_mdio.c > +++ b/drivers/of/of_mdio.c > @@ -83,7 +83,6 @@ int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np) > addr); > continue; > } > - phy_scan_fixups(phy); > > /* Associate the OF node with the device structure so it > * can be looked up later */ > -- > 1.7.2.5 > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-25 4:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1319144425-15547-1-git-send-email-Kyle.D.Moffett@boeing.com>
2011-10-20 21:00 ` [RFC PATCH 02/17] of_mdio: Don't phy_scan_fixups() twice Kyle Moffett
2011-10-25 4:56 ` Grant Likely
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).