From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
To: Greg KH <gregkh-l3A5Bk7waGM@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Sven Schnelle <svens-yWSVVCS59A8YeIxN5WHPnw@public.gmane.org>
Subject: Re: [PATCH] tty/serial: atmel_serial: fix compilation
Date: Sat, 29 Oct 2011 13:49:50 +0200 [thread overview]
Message-ID: <20111029114950.GB22592@ponder.secretlab.ca> (raw)
In-Reply-To: <20111028131811.GA25743-l3A5Bk7waGM@public.gmane.org>
On Fri, Oct 28, 2011 at 03:18:11PM +0200, Greg KH wrote:
> On Fri, Oct 28, 2011 at 02:38:09PM +0200, Nicolas Ferre wrote:
> > On 10/28/2011 01:33 PM, Sven Schnelle :
> > > If CONFIG_OF is disabled, compilation fails with:
> > >
> > > drivers/tty/serial/atmel_serial.c: In function 'atmel_serial_probe':
> > > drivers/tty/serial/atmel_serial.c:1788: error: implicit declaration of function 'of_alias_get_id'
> > >
> > > Fix this by adding the proper CONFIG_OF checks.
> >
> > Yes, but I would like to avoid this and I have made a patch to address
> > this issue. I have sent it to the device tree guys yesterday:
> > "[PATCH] dt: add empty of_alias_get_id() for non-dt builds"
> >
> > Maybe we can wait a little and see if it reaches Linus' tree on time. If
> > it is not, I will make sure that such a fix make it to mainline.
>
> I agree, the other dt: patch is the correct way to fix this, not this
> driver-only #ifdef hack.
I've picked up the of_alias_get_id patch now.
g.
prev parent reply other threads:[~2011-10-29 11:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1319801631-14654-1-git-send-email-svens@stackframe.org>
[not found] ` <1319801631-14654-1-git-send-email-svens-yWSVVCS59A8YeIxN5WHPnw@public.gmane.org>
2011-10-28 12:38 ` [PATCH] tty/serial: atmel_serial: fix compilation Nicolas Ferre
2011-10-28 13:18 ` Greg KH
[not found] ` <20111028131811.GA25743-l3A5Bk7waGM@public.gmane.org>
2011-10-29 11:49 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111029114950.GB22592@ponder.secretlab.ca \
--to=grant.likely-s3s/wqlpoipyb63q8fvjnq@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=gregkh-l3A5Bk7waGM@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=svens-yWSVVCS59A8YeIxN5WHPnw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).