devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Olof Johansson <olof@lixom.net>
Cc: Rajendra Nayak <rnayak@ti.com>,
	grant.likely@secretlab.ca, patches@linaro.org, tony@atomide.com,
	devicetree-discuss@lists.ozlabs.org,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	lrg@ti.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/4] regulator: adapt fixed regulator driver to dt
Date: Fri, 4 Nov 2011 22:23:23 +0000	[thread overview]
Message-ID: <20111104222323.GB16978@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAOesGMh-fpUSMvOGkq_b4DVzFUby6pnMmKDXQ=sFJpn+g4FzOw@mail.gmail.com>

On Fri, Nov 04, 2011 at 03:09:32PM -0700, Olof Johansson wrote:

> But even things like allowing (optional) attributes such as
> startup-delay on non-fixed regulators could make sense. Keep in mind
> that the device tree should focus on describing the hardware, not just
> what the linux driver needs from it. So maybe instead of
> startup-delay, specifying ramp-up speed instead of time needed until
> power is good could be the way to go there.

This is in general something that a driver should know as a result of
knowing which regulator it's dealing with - in many cases these are
properties which can be varied at runtime on hardware which has register
control.  Replicating this into the device tree would make things more
error prone.

  reply	other threads:[~2011-11-04 22:23 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-27  7:56 [PATCH v3 0/4] Device tree support for regulators Rajendra Nayak
     [not found] ` <1319702185-16108-1-git-send-email-rnayak-l0cyMroinI0@public.gmane.org>
2011-10-27  7:56   ` [PATCH v3 1/4] regulator: helper routine to extract regulator_init_data Rajendra Nayak
2011-10-27  8:09     ` Mark Brown
2011-10-27 10:43       ` Nayak, Rajendra
2011-10-27 11:49         ` Mark Brown
2011-10-27 13:27           ` Rajendra Nayak
2011-10-27  7:56   ` [PATCH v3 2/4] regulator: adapt fixed regulator driver to dt Rajendra Nayak
     [not found]     ` <1319702185-16108-3-git-send-email-rnayak-l0cyMroinI0@public.gmane.org>
2011-10-27 12:18       ` Mark Brown
2011-11-04 20:34     ` Olof Johansson
2011-11-04 21:01       ` Mark Brown
2011-11-04 21:18         ` Olof Johansson
2011-11-04 21:25           ` Mark Brown
2011-11-04 21:47             ` Olof Johansson
2011-11-04 21:57               ` Mark Brown
2011-11-04 22:09                 ` Olof Johansson
2011-11-04 22:23                   ` Mark Brown [this message]
     [not found]       ` <20111104203422.GB3918-O5ziIzlqnXUVNXGz7ipsyg@public.gmane.org>
2011-11-07  6:27         ` Rajendra Nayak
2011-10-27  7:56   ` [PATCH v3 3/4] regulator: pass additional of_node to regulator_register() Rajendra Nayak
     [not found]     ` <1319702185-16108-4-git-send-email-rnayak-l0cyMroinI0@public.gmane.org>
2011-10-27 12:20       ` Mark Brown
2011-10-27  7:56   ` [PATCH v3 4/4] regulator: map consumer regulator based on device tree Rajendra Nayak
2011-10-27 12:20     ` Mark Brown
2011-10-27  9:08 ` [PATCH v3 0/4] Device tree support for regulators Mark Brown
2011-11-04 20:21   ` Olof Johansson
     [not found]     ` <CAOesGMii8v3DOCjWpuF3=+EVu+-HYGys=7RRgpk+9U=FxTHwOA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-11-04 21:02       ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111104222323.GB16978@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=olof@lixom.net \
    --cc=patches@linaro.org \
    --cc=rnayak@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).