From: Tony Lindgren <tony@atomide.com>
To: Rajendra Nayak <rnayak@ti.com>
Cc: linux-mmc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
grant.likely@secretlab.ca, rob.herring@calxeda.com,
thomas.abraham@linaro.org, balajitk@ti.com, cjb@laptop.org
Subject: Re: [PATCH 2/4] mmc: omap: adapt the hsmmc driver to device tree
Date: Mon, 14 Nov 2011 13:30:27 -0800 [thread overview]
Message-ID: <20111114213026.GP31337@atomide.com> (raw)
In-Reply-To: <1320407441-29697-3-git-send-email-rnayak@ti.com>
* Rajendra Nayak <rnayak@ti.com> [111104 04:16]:
> @@ -1869,6 +1957,14 @@ static int __init omap_hsmmc_probe(struct platform_device *pdev)
> struct omap_hsmmc_host *host = NULL;
> struct resource *res;
> int ret, irq;
> + const struct of_device_id *match;
> +
> + match = of_match_device(omap_mmc_of_match, &pdev->dev);
> + if (match) {
> + pdata = of_get_hsmmc_pdata(&pdev->dev);
> + if (match->data)
> + pdata->reg_offset = *(u16 *)match->data;
> + }
So this is now using both DT and pdata?
We want to use DT only, and get rid of pdata. Other than the
deferred probe, is there some other dependency remaining to
having to use the pdata also?
Regards,
Tony
next prev parent reply other threads:[~2011-11-14 21:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-04 11:50 [PATCH 0/4] omap hsmmc device tree support Rajendra Nayak
2011-11-04 11:50 ` [PATCH 1/4] mmc: Add additional binding for mmc host controller Rajendra Nayak
2011-11-04 19:58 ` Olof Johansson
2011-11-04 11:50 ` [PATCH 2/4] mmc: omap: adapt the hsmmc driver to device tree Rajendra Nayak
2011-11-04 20:04 ` Olof Johansson
2011-11-04 21:25 ` Cousson, Benoit
2011-11-04 21:28 ` Olof Johansson
2011-11-07 6:14 ` Rajendra Nayak
2011-11-04 22:15 ` Segher Boessenkool
2011-11-07 6:18 ` Rajendra Nayak
2011-11-14 21:30 ` Tony Lindgren [this message]
2011-11-15 4:15 ` Rajendra Nayak
2011-11-19 0:21 ` Tony Lindgren
2011-11-04 11:50 ` [PATCH 3/4] omap4: mmc: Pass SoC and board data for omap4 mmc from dt Rajendra Nayak
2011-11-04 11:50 ` [PATCH 4/4] omap4: mmc: use auxdata to pass platform function ptrs Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111114213026.GP31337@atomide.com \
--to=tony@atomide.com \
--cc=balajitk@ti.com \
--cc=cjb@laptop.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rnayak@ti.com \
--cc=rob.herring@calxeda.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).