From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 14/17] ASoC: Implement "auto nc pins" feature Date: Wed, 23 Nov 2011 11:15:10 +0000 Message-ID: <20111123111510.GH21073@opensource.wolfsonmicro.com> References: <1322011285-4002-1-git-send-email-swarren@nvidia.com> <1322011285-4002-15-git-send-email-swarren@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1322011285-4002-15-git-send-email-swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stephen Warren Cc: Liam Girdwood , Olof Johansson , Colin Cross , alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Mike Rapoport , John Bonesio , Grant Likely , Marc Dietrich , Leon Romanovsky , Peter De Schrijver , Rob Herring , Ian Lartey , Dimitris Papastamos List-Id: devicetree@vger.kernel.org On Tue, Nov 22, 2011 at 06:21:22PM -0700, Stephen Warren wrote: > Codecs often have a large number of external pins, and not all of these pins > will be connected on all board designs. Some machine drivers therefore call > snd_soc_dapm_nc_pin() for all the unused pins, in order to tell the ASoC core > never to activate them. This looks good from a code point of view but can you please rename the flag that needs to be set to something like "fully_routed" so that if we think of anything else we can do with a fully specified card routing map then the flag name doesn't look wrong.