From: Dave Martin <dave.martin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>
Subject: Re: [PATCH v2 0/4] Versatile Express DT support
Date: Mon, 28 Nov 2011 14:42:45 +0000 [thread overview]
Message-ID: <20111128144245.GB2465@localhost.localdomain> (raw)
In-Reply-To: <4ED399C8.9080908-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Mon, Nov 28, 2011 at 08:25:12AM -0600, Rob Herring wrote:
> On 11/23/2011 09:01 AM, Pawel Moll wrote:
> > Hello again,
> >
> > This version of the series (hopefully) addresses all the suggestions
> > made by Dave, Rob and Russell.
> >
> > The compatible values are specific for the tiles now and the memory
> > map variant is defined as a custom property in the motherboard node.
> >
> > Tested on V2P-CA9 coretile both with ATAGs and DT and V2P-CA5s with DT.
> >
> > All comments, as always, welcomed!
> >
> > Pawel
> >
> >
> >
> > Pawel Moll (4):
> > ARM: vexpress: Get rid of MMIO_P2V
> > ARM: vexpress: Add DT support in v2m
> > ARM: vexpress: Initial RS1 memory map support
> > ARM: vexpress: DT-based support for CoreTiles Express A5x2 and A9x4
> >
> > Documentation/devicetree/bindings/arm/vexpress | 101 ++++++++
> > arch/arm/boot/dts/vexpress-v2m-rs1.dtsi | 192 +++++++++++++++
> > arch/arm/boot/dts/vexpress-v2m.dtsi | 191 +++++++++++++++
> > arch/arm/boot/dts/vexpress-v2p-ca5s.dts | 132 ++++++++++
> > arch/arm/boot/dts/vexpress-v2p-ca9.dts | 146 +++++++++++
> > arch/arm/include/asm/hardware/arm_timer.h | 5 +
> > arch/arm/mach-vexpress/Kconfig | 35 +++
> > arch/arm/mach-vexpress/Makefile | 1 +
> > arch/arm/mach-vexpress/Makefile.boot | 6 +
> > arch/arm/mach-vexpress/core.h | 21 ++-
> > arch/arm/mach-vexpress/ct-ca9x4.c | 52 +---
> > arch/arm/mach-vexpress/include/mach/ct-ca9x4.h | 13 +-
> > arch/arm/mach-vexpress/include/mach/debug-macro.S | 37 +++-
> > arch/arm/mach-vexpress/include/mach/motherboard.h | 58 +++--
> > arch/arm/mach-vexpress/include/mach/uncompress.h | 13 +-
> > arch/arm/mach-vexpress/platsmp.c | 4 +-
> > arch/arm/mach-vexpress/v2m.c | 265 ++++++++++++++++++---
> > arch/arm/mach-vexpress/v2p-ca5s_ca9.c | 115 +++++++++
> > 18 files changed, 1272 insertions(+), 115 deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/arm/vexpress
> > create mode 100644 arch/arm/boot/dts/vexpress-v2m-rs1.dtsi
> > create mode 100644 arch/arm/boot/dts/vexpress-v2m.dtsi
> > create mode 100644 arch/arm/boot/dts/vexpress-v2p-ca5s.dts
> > create mode 100644 arch/arm/boot/dts/vexpress-v2p-ca9.dts
> > create mode 100644 arch/arm/mach-vexpress/v2p-ca5s_ca9.c
>
> Other than Dave's comments, looks good. For the series:
>
> Acked-by: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
>
> There are a number of compatible strings for various peripherals defined
> without documentation, but you're not really using them so I think it's
> fine for now. BTW, I believe Dave said he was going to document some of
> the primecell peripherals. :)
I hadn't forgotten ... I was going to follow up on those shortly :)
Cheers
---Dave
next prev parent reply other threads:[~2011-11-28 14:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 15:01 [PATCH v2 0/4] Versatile Express DT support Pawel Moll
2011-11-23 15:01 ` [PATCH v2 1/4] ARM: vexpress: Get rid of MMIO_P2V Pawel Moll
[not found] ` <1322060508-11298-2-git-send-email-pawel.moll-5wv7dgnIgG8@public.gmane.org>
2011-11-25 16:15 ` Dave Martin
2011-11-28 10:40 ` Pawel Moll
[not found] ` <20111125161500.GD2098-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2011-11-28 10:44 ` Russell King - ARM Linux
[not found] ` <20111128104416.GD9581-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2011-11-28 10:53 ` Dave Martin
2011-11-23 15:01 ` [PATCH v2 2/4] ARM: vexpress: Add DT support in v2m Pawel Moll
2011-11-23 16:10 ` Pawel Moll
[not found] ` <1322060508-11298-3-git-send-email-pawel.moll-5wv7dgnIgG8@public.gmane.org>
2011-11-25 16:18 ` Dave Martin
2011-11-28 10:54 ` Pawel Moll
[not found] ` <1322477662.3164.30.camel-okZbbLrgpR/YkXV2EHHjLW3o5bpOHsLO@public.gmane.org>
2011-11-28 11:38 ` Dave Martin
2011-11-23 15:01 ` [PATCH v2 3/4] ARM: vexpress: Initial RS1 memory map support Pawel Moll
2011-11-23 15:01 ` [PATCH v2 4/4] ARM: vexpress: DT-based support for CoreTiles Express A5x2 and A9x4 Pawel Moll
[not found] ` <1322060508-11298-5-git-send-email-pawel.moll-5wv7dgnIgG8@public.gmane.org>
2011-11-28 16:29 ` Dave Martin
2011-11-28 17:00 ` Pawel Moll
[not found] ` <1322499602.3164.73.camel-okZbbLrgpR/YkXV2EHHjLW3o5bpOHsLO@public.gmane.org>
2011-11-28 17:08 ` Dave Martin
[not found] ` <1322060508-11298-1-git-send-email-pawel.moll-5wv7dgnIgG8@public.gmane.org>
2011-11-28 14:25 ` [PATCH v2 0/4] Versatile Express DT support Rob Herring
[not found] ` <4ED399C8.9080908-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-11-28 14:42 ` Dave Martin [this message]
2011-11-28 14:57 ` Dave Martin
2011-11-28 15:09 ` Pawel Moll
[not found] ` <1322492947.3164.44.camel-okZbbLrgpR/YkXV2EHHjLW3o5bpOHsLO@public.gmane.org>
2011-11-28 15:14 ` Dave Martin
2011-11-28 15:20 ` Pawel Moll
[not found] ` <1322493617.3164.56.camel-okZbbLrgpR/YkXV2EHHjLW3o5bpOHsLO@public.gmane.org>
2011-11-28 15:39 ` Rob Herring
2011-11-28 16:02 ` Pawel Moll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111128144245.GB2465@localhost.localdomain \
--to=dave.martin-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).