From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Martin Subject: Re: [PATCH v3 5/5] ARM: vexpress: DT-based support for CoreTiles Express A5x2 and A9x4 Date: Thu, 1 Dec 2011 12:21:44 +0000 Message-ID: <20111201122144.GD2026@localhost.localdomain> References: <1322579473-8804-1-git-send-email-pawel.moll@arm.com> <1322579473-8804-6-git-send-email-pawel.moll@arm.com> <20111129164050.GC2829@localhost.localdomain> <1322678364.3180.34.camel@hornet.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1322678364.3180.34.camel-okZbbLrgpR/YkXV2EHHjLW3o5bpOHsLO@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Pawel Moll Cc: "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org On Wed, Nov 30, 2011 at 06:39:24PM +0000, Pawel Moll wrote: > On Tue, 2011-11-29 at 16:40 +0000, Dave Martin wrote: > > Note that select PL310_ERRATA_753970 if CACHE_PL310 also needs to be > > propagated to ARCH_VEXPRESS_CA9X4. Maybe we should have a common symbol > > which selects/depends on the common stuff instead of duplicating it for > > every coretile -- they will tend to get out of sync. > > How about that? > > 8<-------------------------------------------------------------- > menu "Versatile Express platform type" > depends on ARCH_VEXPRESS > > config ARCH_VEXPRESS_CORTEX_A5_A9 > bool > select ARM_ERRATA_720789 > select ARM_ERRATA_751472 > select ARM_GIC > select CPU_V7 > select HAVE_L2X0_L2CC > select PL310_ERRATA_753970 if CACHE_PL310 > help > VE platforms based on Cortex-A5 or Cortex-A9 processors. That will work, but we should make it clear that this option does not provide board support all by itself, maybe: "Provides common dependencies for VE platforms based on Cortex-A5 or Cortex-A9 processors. In order to build a working kernel, you must also enable one or more core tile support options." Cheers ---Dave