From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 1/5] ASoC: omap-dmic: Add device tree bindings Date: Fri, 2 Dec 2011 12:25:58 +0000 Message-ID: <20111202122558.GM8245@opensource.wolfsonmicro.com> References: <1322819580-7424-1-git-send-email-peter.ujfalusi@ti.com> <1322819580-7424-2-git-send-email-peter.ujfalusi@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1322819580-7424-2-git-send-email-peter.ujfalusi@ti.com> Sender: linux-omap-owner@vger.kernel.org To: Peter Ujfalusi Cc: Liam Girdwood , Tony Lindgren , Benoit Cousson , Misael Lopez Cruz , alsa-devel@alsa-project.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree-discuss@lists.ozlabs.org List-Id: devicetree@vger.kernel.org On Fri, Dec 02, 2011 at 11:52:56AM +0200, Peter Ujfalusi wrote: > +Required properties: > + - compatible : "ti,omap4-dmic" > + - ti,hwmods : List of hwmod names associated with DMIC, in most case > + it is "dmic". Shouldn't there also be a regs property giving the register window?