From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Martin Subject: Re: [PATCH] ata: Don't use NO_IRQ in pata_of_platform driver Date: Tue, 6 Dec 2011 13:25:27 +0000 Message-ID: <20111206132527.GA13780@linaro.org> References: <20111205161157.GA27550@localhost.localdomain> <20111205180253.GB29812@localhost.localdomain> <20111205192605.GD29812@localhost.localdomain> <20111206093709.GB2274@linaro.org> <20111206104654.GN14542@n2100.arm.linux.org.uk> <20111206113735.GC2274@linaro.org> <20111206114952.GS14542@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20111206114952.GS14542@n2100.arm.linux.org.uk> Sender: linux-ide-owner@vger.kernel.org To: Russell King - ARM Linux Cc: Nicolas Pitre , Stephen Rothwell , Pawel Moll , Benjamin Herrenschmidt , devicetree-discuss@lists.ozlabs.org, LKML , Jeff Garzik , linux-ide@vger.kernel.org, Randy Dunlap , linux-next@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Anton Vorontsov , Andrew Morton , Linus Torvalds , Ingo Molnar , Alan Cox List-Id: devicetree@vger.kernel.org On Tue, Dec 06, 2011 at 11:49:52AM +0000, Russell King - ARM Linux wrote: > On Tue, Dec 06, 2011 at 11:37:35AM +0000, Dave Martin wrote: > > 1) All OF code and drivers should be migrating to use 0 instead of NO_IRQ > > for the no-interrupt case. Code which receives irq numbers directly > > from the OF framework and refers to NO_IRQ, or expects 0 to be a valid > > needs to be fixed. > > > > 2) Where we hit a problem, board code needs to be adapted to remap HW IRQs > > 0-15 to different software values. (This could be done using irq > > domains, or not) > > No AMBA driver I'm aware of ever uses an IRQ number 0 or is passed such > an IRQ number. OK, hopefully we can safely ignore that case, then. But other than that, you're in agreement? Cheers ---Dave