From: Tony Lindgren <tony@atomide.com>
To: Rajendra Nayak <rnayak@ti.com>
Cc: linux-serial@vger.kernel.org, linux-omap@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org, khilman@ti.com,
govindraj.raja@ti.com, b-cousson@ti.com,
linux-arm-kernel@lists.infradead.org,
linaro-dev@lists.linaro.org, patches@linaro.org,
robherring2@gmail.com
Subject: Re: [PATCH v3 4/4] ARM: omap: pass minimal SoC/board data for UART from dt
Date: Wed, 14 Dec 2011 11:25:10 -0800 [thread overview]
Message-ID: <20111214192509.GH32251@atomide.com> (raw)
In-Reply-To: <1323863746-18145-5-git-send-email-rnayak@ti.com>
* Rajendra Nayak <rnayak@ti.com> [111214 03:24]:
> Pass minimal data needed for console boot, from dt, for
> OMAP4 panda/sdp and OMAP3 beagle boards, and get rid of the
> static initialization from generic board file.
>
> Acked-by: Rob Herring <rob.herring@calxeda.com>
> Signed-off-by: Rajendra Nayak <rnayak@ti.com>
This we can't merge because this breaks serial console for
omap2 because you're not adding the omap2 specific dtsi
entries for omap2..
> --- a/arch/arm/mach-omap2/board-generic.c
> +++ b/arch/arm/mach-omap2/board-generic.c
> @@ -69,7 +69,6 @@ static void __init omap_generic_init(void)
> if (node)
> irq_domain_add_simple(node, 0);
>
> - omap_serial_init();
> omap_sdrc_init(NULL, NULL);
>
> of_platform_populate(NULL, omap_dt_match_table, NULL, NULL);
..and you're removing the call for omap_serial_init.
Please just update this patch with the omap2 entries
as well. Other than that looks good to me.
Tony
next prev parent reply other threads:[~2011-12-14 19:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 11:55 [PATCH v3 0/4] OMAP serial device tree support Rajendra Nayak
2011-12-14 11:55 ` [PATCH v3 1/4] omap-serial: Get rid of all pdev->id usage Rajendra Nayak
2011-12-14 11:55 ` [PATCH v3 2/4] omap-serial: Use default clock speed (48Mhz) if not specified Rajendra Nayak
2011-12-14 11:55 ` [PATCH v3 3/4] omap-serial: Add minimal device tree support Rajendra Nayak
2011-12-14 11:55 ` [PATCH v3 4/4] ARM: omap: pass minimal SoC/board data for UART from dt Rajendra Nayak
2011-12-14 19:25 ` Tony Lindgren [this message]
2011-12-15 6:52 ` Rajendra Nayak
2011-12-15 10:06 ` Cousson, Benoit
2011-12-15 21:13 ` Tony Lindgren
2011-12-15 21:28 ` Cousson, Benoit
2011-12-15 21:37 ` Tony Lindgren
2011-12-15 21:39 ` [PATCH] arm/dts: Add minimal device tree support for omap2420 and omap2430 Tony Lindgren
2011-12-16 4:01 ` Rajendra Nayak
2011-12-16 15:21 ` [PATCH v3 4/4] ARM: omap: pass minimal SoC/board data for UART from dt Cousson, Benoit
[not found] ` <1323863746-18145-5-git-send-email-rnayak-l0cyMroinI0@public.gmane.org>
2012-04-11 0:16 ` Ramirez Luna, Omar
2012-04-11 8:39 ` Cousson, Benoit
2012-04-11 15:57 ` Ramirez Luna, Omar
2011-12-14 13:47 ` [PATCH v3 0/4] OMAP serial device tree support Rob Herring
2011-12-16 21:57 ` Tony Lindgren
2011-12-16 22:02 ` Rob Herring
2011-12-16 22:09 ` Tony Lindgren
2011-12-14 14:41 ` Govindraj
2011-12-14 15:20 ` Kevin Hilman
2011-12-14 17:18 ` Alan Cox
2011-12-14 18:27 ` Greg KH
2011-12-16 22:17 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111214192509.GH32251@atomide.com \
--to=tony@atomide.com \
--cc=b-cousson@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=govindraj.raja@ti.com \
--cc=khilman@ti.com \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=patches@linaro.org \
--cc=rnayak@ti.com \
--cc=robherring2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).