From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Zhao Subject: Re: [PATCH v4 4/7] cpufreq: add clk-reg cpufreq driver Date: Sat, 24 Dec 2011 16:55:42 +0800 Message-ID: <20111224085539.GA1892@richard-laptop> References: <1324537753-30590-1-git-send-email-richard.zhao@linaro.org> <1324537753-30590-5-git-send-email-richard.zhao@linaro.org> <20111223131851.GB13175@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20111223131851.GB13175@sirena.org.uk> Sender: cpufreq-owner@vger.kernel.org To: Mark Brown Cc: linux-arm-kernel@lists.infradead.org, cpufreq@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linux@arm.linux.org.uk, davej@redhat.com, grant.likely@secretlab.ca, rob.herring@calxeda.com, rdunlap@xenotime.net, kernel@pengutronix.de, shawn.guo@linaro.org, catalin.marinas@arm.com, eric.miao@linaro.org, mark.langsdorf@calxeda.com, davidb@codeaurora.org, arnd@arndb.de, bryanh@codeaurora.org, jamie@jamieiles.com, marc.zyngier@arm.com, linaro-dev@lists.linaro.org, patches@linaro.org List-Id: devicetree@vger.kernel.org On Fri, Dec 23, 2011 at 01:18:51PM +0000, Mark Brown wrote: > On Thu, Dec 22, 2011 at 03:09:10PM +0800, Richard Zhao wrote: > > The driver get cpu operation point table from device tree cpu0 node, > > and adjusts operating points using clk and regulator APIs. > > Reviewed-by: Mark Brown > Thanks. > but one nit: > > > +Required properties in /cpus/cpu@0: > > +- cpu-freqs : cpu frequency points it support, in unit of Hz. > > +- cpu-volts : cpu voltages required by the frequency point at the same index, > > + in unit of uV. > > +- trans-latency : transition_latency, in unit of ns. > > trans-latency should really say what latency is being measured (the CPU > core only or the whole operation). dts only descibe hw info. so the transition latency is for hw. - trans-latency : transition latency of HW, in unit of ns. Thanks Richard