From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 2/2] ARM: Exynos: Hook up power domains to generic power domain infrastructure Date: Mon, 26 Dec 2011 19:06:17 +0000 Message-ID: <20111226190616.GL8722@opensource.wolfsonmicro.com> References: <1323704789-23923-1-git-send-email-thomas.abraham@linaro.org> <1323704789-23923-2-git-send-email-thomas.abraham@linaro.org> <1323704789-23923-3-git-send-email-thomas.abraham@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1323704789-23923-3-git-send-email-thomas.abraham@linaro.org> Sender: linux-samsung-soc-owner@vger.kernel.org To: Thomas Abraham Cc: linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, rjw@sisk.pl, linux-arm-kernel@lists.infradead.org, devicetree-discuss@lists.ozlabs.org, rob.herring@calxeda.com, grant.likely@secretlab.ca, kgene.kim@samsung.com, patches@linaro.org List-Id: devicetree@vger.kernel.org On Mon, Dec 12, 2011 at 09:16:29PM +0530, Thomas Abraham wrote: > + /* Wait max 1ms */ > + timeout = 10; > + while ((__raw_readl(base + 0x4) & S5P_INT_LOCAL_PWR_EN) > + != S5P_INT_LOCAL_PWR_EN) { > + if (!timeout) { > + pr_err("Power domain %s enable failed\n", domain->name); > + return -ETIMEDOUT; > + } > + timeout--; > + udelay(100); > + } Might be worth putting a cpu_relax() in there just to be a bit nicer?