From: Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rakesh Iyer <riyer-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
Grant Likely
<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Subject: Re: [PATCH v2 2/2] Input: tegra-kbc - add default chromeos map
Date: Tue, 27 Dec 2011 22:50:13 -0800 [thread overview]
Message-ID: <20111228065013.GB29273@core.coreip.homeip.net> (raw)
In-Reply-To: <1325053170-6984-3-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
On Tue, Dec 27, 2011 at 10:19:30PM -0800, Olof Johansson wrote:
> This adds a simple way to specify the ChromeOS-specific keyboard map
> instead of the "standard" map that is used on other Tegra devices such
> as Harmony-with-keyboard and Seaboard.
>
> I expect the number of different keyboard layouts to be quite limited,
> and not many should be added over time. So instead of encoding the layout
> in the device tree, with all the can of worms that entails w.r.t. agreeing
> on a suitable binding, just add a property to specify that this is the
> map to be used, and include it in the driver.
>
> If, over time, the number of mappings increase, the binding can be
> updated to include a custom map as a new property, without having to
> worry about backwards compatibility on existing devices.
>
I'd rather we did not make shortcuts and did the proper DT binding.
Samsung folks want the similar thing so making a generic DT keymap
parser and using it in the driver would be the best way.
Another option is to simply loading proper keymap by the early
userspace.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2011-12-28 6:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-28 6:19 [PATCH v2 0/2] Input: tegra-kbc - configure through device tree Olof Johansson
[not found] ` <1325053170-6984-1-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
2011-12-28 6:19 ` [PATCH v2 1/2] Input: tegra-kbc - add device tree bindings Olof Johansson
[not found] ` <1325053170-6984-2-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
2011-12-28 6:48 ` Dmitry Torokhov
[not found] ` <20111228064832.GA29273-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2011-12-28 7:10 ` Olof Johansson
2011-12-29 6:00 ` Stephen Warren
[not found] ` <74CDBE0F657A3D45AFBB94109FB122FF17755DC8CE-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2011-12-29 9:23 ` Dmitry Torokhov
[not found] ` <20111229092308.GA3397-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2012-01-02 8:16 ` Grant Likely
2012-01-02 8:18 ` Grant Likely
[not found] ` <20120102081828.GB18381-e0URQFbLeQY2iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2012-01-03 20:58 ` Olof Johansson
2011-12-28 6:19 ` [PATCH v2 2/2] Input: tegra-kbc - add default chromeos map Olof Johansson
[not found] ` <1325053170-6984-3-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
2011-12-28 6:50 ` Dmitry Torokhov [this message]
[not found] ` <20111228065013.GB29273-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2011-12-28 7:33 ` Olof Johansson
[not found] ` <CAOesGMheQqYjpDRaf6TTce2YEcD4hkTzS2JTdoCe3ue6+dBhDQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-12-29 6:06 ` Stephen Warren
[not found] ` <74CDBE0F657A3D45AFBB94109FB122FF17755DC8D0-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2011-12-29 6:41 ` Olof Johansson
[not found] ` <CAOesGMi6CpVVjUS4EoXbtxdw=Wj8G2_+SFzvqp1DP_mpjCoNVA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-12-29 6:58 ` Stephen Warren
[not found] ` <74CDBE0F657A3D45AFBB94109FB122FF17755DC8D9-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2011-12-29 7:13 ` Olof Johansson
[not found] ` <CAOesGMh=MESRSs0YeFJpf__E7FNmPY4zdNjz7hBqMuiWbUJsow-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-12-29 9:41 ` Dmitry Torokhov
[not found] ` <20111229094106.GB3397-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2011-12-29 9:47 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111228065013.GB29273@core.coreip.homeip.net \
--to=dmitry.torokhov-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
--cc=riyer-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).