From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Richard Zhao <richard.zhao@linaro.org>
Cc: Richard Zhao <richard.zhao@freescale.com>,
linaro-dev@lists.linaro.org, linux@arm.linux.org.uk,
mark.langsdorf@calxeda.com, arnd@arndb.de, patches@linaro.org,
marc.zyngier@arm.com, catalin.marinas@arm.com,
devicetree-discuss@lists.ozlabs.org, rdunlap@xenotime.net,
cpufreq@vger.kernel.org, grant.likely@secretlab.ca,
bryanh@codeaurora.org, eric.miao@linaro.org,
rob.herring@calxeda.com, kernel@pengutronix.de, davej@redhat.com,
jamie@jamieiles.com, davidb@codeaurora.org, shawn.guo@linaro.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V5 4/7] cpufreq: add clk-reg cpufreq driver
Date: Wed, 28 Dec 2011 12:47:40 +0000 [thread overview]
Message-ID: <20111228124739.GK24405@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20111228124054.GB1691@richard-laptop>
On Wed, Dec 28, 2011 at 08:40:56PM +0800, Richard Zhao wrote:
> On Wed, Dec 28, 2011 at 12:14:04PM +0000, Mark Brown wrote:
> > On Wed, Dec 28, 2011 at 08:05:20PM +0800, Richard Zhao wrote:
> >
> > Looks like the problem with your mail client is that it's wrapping at
> > exactly 80 characters which is too little - you need to leave space for
> > being quoted.
> I'm using vim. any suggestion for auto-wrapping?
:set tw=72
It'd also be useful to leave blank lines
> > > > You can't usefully work with voltages without knowing what the actual
> > > > voltages are
> if people don't enable REGULATOR, the stubs (if you mean the dummy func)
> are only be used to pass build. The code is optimized out by compiler.
No, this is not the case. All the functions have return values which
still need to be handled gracefully by drivers using those functions.
> > - the only sensible stubs we could provide would return
> > > > errors but then any driver using the stubs would probably fail to do
> > > > whatever it was doing.
> In this case, If regulator_get return NULL, I won't call other regulator
> functions at runtime.
That should be OK for your use case but it might not be sensible for
other cases. Any stubs for this provided by the core need to work well
for any user.
> > > - I saw linux/regulator/consumer.h has some dummy functions if !REGULATOR. I
> > > tried to make clk-reg-cpufreq driver work even !REGULATOR. I think that's
> > > why the dummy functions are there. If regulator_get return NULL, it'll avoid
> > > calling other regulator functions. But regulator_is_supported_voltage and
> > > regulator_set_voltage_time don't have such dummy ones. Undefined functions.
> > I can only repeat what I wrote above explaining why no stubs are
> > provided.
> One word. You mean I have to always depends on REGULATOR config, right?
Yes.
next prev parent reply other threads:[~2011-12-28 12:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-27 8:24 [PATCH V5 0/7] add a generic cpufreq driver Richard Zhao
2011-12-27 8:24 ` [PATCH V5 1/7] ARM: add cpufreq transiton notifier to adjust loops_per_jiffy for smp Richard Zhao
2011-12-27 8:24 ` [PATCH V5 2/7] arm/imx: cpufreq: remove loops_per_jiffy recalculate " Richard Zhao
2011-12-27 8:24 ` [PATCH V5 3/7] cpufreq: OMAP: " Richard Zhao
2011-12-27 8:24 ` [PATCH V5 4/7] cpufreq: add clk-reg cpufreq driver Richard Zhao
2011-12-27 15:05 ` Shawn Guo
2011-12-28 1:24 ` Richard Zhao
2011-12-28 2:01 ` Shawn Guo
2011-12-28 3:31 ` Shawn Guo
2011-12-28 3:14 ` Richard Zhao
2011-12-28 3:31 ` Richard Zhao
2011-12-28 11:42 ` Mark Brown
2011-12-28 12:05 ` Richard Zhao
2011-12-28 12:14 ` Mark Brown
2011-12-28 12:40 ` Richard Zhao
2011-12-28 12:47 ` Mark Brown [this message]
2011-12-28 13:06 ` Shawn Guo
2011-12-28 12:54 ` Mark Brown
2011-12-28 13:10 ` Shawn Guo
2011-12-29 6:21 ` Richard Zhao
2011-12-29 7:23 ` Shawn Guo
2011-12-27 8:24 ` [PATCH V5 5/7] dts/imx6q: add cpufreq property Richard Zhao
2011-12-27 8:24 ` [PATCH V5 6/7] arm/imx6q: register arm_clk as cpu to clkdev Richard Zhao
2011-12-27 8:24 ` [PATCH V5 7/7] arm/imx6q: select ARCH_HAS_CPUFREQ Richard Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111228124739.GK24405@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=arnd@arndb.de \
--cc=bryanh@codeaurora.org \
--cc=catalin.marinas@arm.com \
--cc=cpufreq@vger.kernel.org \
--cc=davej@redhat.com \
--cc=davidb@codeaurora.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=eric.miao@linaro.org \
--cc=grant.likely@secretlab.ca \
--cc=jamie@jamieiles.com \
--cc=kernel@pengutronix.de \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=marc.zyngier@arm.com \
--cc=mark.langsdorf@calxeda.com \
--cc=patches@linaro.org \
--cc=rdunlap@xenotime.net \
--cc=richard.zhao@freescale.com \
--cc=richard.zhao@linaro.org \
--cc=rob.herring@calxeda.com \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).