From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH v3] Input: keyboard - add device tree bindings for simple key matrixes Date: Tue, 3 Jan 2012 17:06:15 +0000 Message-ID: <20120103170615.GZ2914@n2100.arm.linux.org.uk> References: <1325184146-3527-1-git-send-email-olof@lixom.net> <1325484557-27695-1-git-send-email-olof@lixom.net> <20120103154317.GA27061@quad.lixom.net> <20120103162929.GY2914@n2100.arm.linux.org.uk> <20120103164431.GA31647@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20120103164431.GA31647-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Dmitry Torokhov Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , U-Boot Mailing List , riyer-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Tue, Jan 03, 2012 at 08:44:32AM -0800, Dmitry Torokhov wrote: > On Tue, Jan 03, 2012 at 04:29:30PM +0000, Russell King - ARM Linux wrote: > > On Tue, Jan 03, 2012 at 08:22:21AM -0800, Simon Glass wrote: > > > Can the Linux key codes fit in 8 bits? > > > > That depends on your point of view. > > > > If you hack on X, then the answer is yes and you ignore the squeels of > > your users when certain key presses get misinterpreted. (The Psion LX > > platform, otherwise known as the Netbook Pro, suffered with this problem.) > > > > If you are a kernel hacker, the answer is no, because key codes currently > > go all the way to 0x300. > > For bootloader environment 0-255 range is probably sufficient though, > the upper keys are somewhat recent additions to the maps... I assume you deem 'recent' to mean 8 years ago - they've been there since at least 2.6.9, which is where the problem I refer to above was first noticed.