devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
To: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 6/6] ARM: at91/board-dt: remove AIC irq domain from board file
Date: Wed, 4 Jan 2012 12:48:18 -0700	[thread overview]
Message-ID: <20120104194818.GD15503@ponder.secretlab.ca> (raw)
In-Reply-To: <9fea5224b3a6544bd07c6e877d12870de9403b98.1323975517.git.nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>

On Thu, Dec 15, 2011 at 08:16:08PM +0100, Nicolas Ferre wrote:
> Adding of irqdomain in AIC code make the specification
> of the irq domain in board file useless.
> 
> Signed-off-by: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>

Acked-by: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>

> ---
>  arch/arm/mach-at91/board-dt.c |   15 +--------------
>  1 files changed, 1 insertions(+), 14 deletions(-)
> 
> diff --git a/arch/arm/mach-at91/board-dt.c b/arch/arm/mach-at91/board-dt.c
> index bb6b434..119eda6 100644
> --- a/arch/arm/mach-at91/board-dt.c
> +++ b/arch/arm/mach-at91/board-dt.c
> @@ -15,8 +15,6 @@
>  #include <linux/init.h>
>  #include <linux/module.h>
>  #include <linux/gpio.h>
> -#include <linux/irqdomain.h>
> -#include <linux/of_irq.h>
>  #include <linux/of_platform.h>
>  
>  #include <mach/hardware.h>
> @@ -88,17 +86,6 @@ static void __init ek_add_device_nand(void)
>  	at91_add_device_nand(&ek_nand_data);
>  }
>  
> -static const struct of_device_id aic_of_match[] __initconst = {
> -	{ .compatible = "atmel,at91rm9200-aic", },
> -	{},
> -};
> -
> -static void __init at91_dt_init_irq(void)
> -{
> -	irq_domain_generate_simple(aic_of_match, 0xfffff000, 0);
> -	at91_init_irq_default();
> -}
> -
>  static void __init at91_dt_device_init(void)
>  {
>  	of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
> @@ -118,7 +105,7 @@ DT_MACHINE_START(at91sam_dt, "Atmel AT91SAM (Device Tree)")
>  	.timer		= &at91sam926x_timer,
>  	.map_io		= at91_map_io,
>  	.init_early	= ek_init_early,
> -	.init_irq	= at91_dt_init_irq,
> +	.init_irq	= at91_init_irq_default,
>  	.init_machine	= at91_dt_device_init,
>  	.dt_compat	= at91_dt_board_compat,
>  MACHINE_END
> -- 
> 1.7.5.4
> 

  parent reply	other threads:[~2012-01-04 19:48 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-15 19:16 [PATCH 0/6] ARM: at91: irqdomain and device tree for AIC and GPIO Nicolas Ferre
     [not found] ` <1323976568-20244-1-git-send-email-nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2011-12-15 19:16   ` [PATCH v4 1/6] ARM: at91/aic: add irq domain and device tree support Nicolas Ferre
2011-12-15 19:16   ` [PATCH 2/6] ARM: at91/gpio: add irqdomain to gpio interrupts Nicolas Ferre
     [not found]     ` <56e135f94dc4d88ab6d586f13e406977c4f4bb35.1323975517.git.nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-01-04 19:42       ` Grant Likely
2011-12-15 19:16   ` [PATCH 3/6] ARM: at91/gpio: add DT support Nicolas Ferre
     [not found]     ` <876f676ec80d2db927e379654be76171ca496422.1323975517.git.nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2011-12-16 10:11       ` Jamie Iles
2012-01-03 16:25         ` Nicolas Ferre
2012-01-03 18:34       ` [PATCH v2 " Nicolas Ferre
     [not found]         ` <1325615688-16860-1-git-send-email-nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-01-04 19:45           ` Grant Likely
2012-01-04 22:04           ` Russell King - ARM Linux
2012-01-05 19:42           ` [PATCH v3 " Nicolas Ferre
     [not found]             ` <1325792566-32700-1-git-send-email-nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-01-05 17:50               ` Nicolas Ferre
2012-01-05 20:03               ` [PATCH v4 " Nicolas Ferre
2011-12-15 19:16   ` [PATCH 4/6] ARM: at91/gpio: add .to_irq gpio_chip handler and rework irq_to_gpio Nicolas Ferre
     [not found]     ` <57a5d54dd158c909a3c854b5bfc873a5f43e60ea.1323975517.git.nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-01-04 19:47       ` Grant Likely
2011-12-15 19:16   ` [PATCH 5/6] ARM: at91/gpio: remove the static specification of gpio_chip.base Nicolas Ferre
     [not found]     ` <62da3cffc145e2ada7ecbf4939a6029eb482d116.1323975517.git.nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-01-04 19:47       ` Grant Likely
2011-12-15 19:16   ` [PATCH 6/6] ARM: at91/board-dt: remove AIC irq domain from board file Nicolas Ferre
     [not found]     ` <9fea5224b3a6544bd07c6e877d12870de9403b98.1323975517.git.nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-01-04 19:48       ` Grant Likely [this message]
2011-12-16  1:53   ` [PATCH 0/6] ARM: at91: irqdomain and device tree for AIC and GPIO Rob Herring
     [not found]     ` <4EEAA4A7.3040902-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-12-16 16:29       ` Nicolas Ferre
     [not found] ` <85d531b5686e5eff623bed9618f802198409905f.1323975517.git.nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-01-04 19:40   ` [PATCH v4 1/6] ARM: at91/aic: add irq domain and device tree support Grant Likely
     [not found]     ` <20120104194059.GY15503-e0URQFbLeQY2iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2012-01-05 16:26       ` Nicolas Ferre
     [not found]         ` <4F05CF48.5050007-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-01-05 18:02           ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120104194818.GD15503@ponder.secretlab.ca \
    --to=grant.likely-s3s/wqlpoipyb63q8fvjnq@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \
    --cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).