From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jamie Iles Subject: Re: [PATCH 5/6] gpio: tegra: Dynamically allocate IRQ base, and support DT Date: Thu, 5 Jan 2012 16:48:57 +0000 Message-ID: <20120105164857.GE10530@page> References: <1325702378-20863-1-git-send-email-swarren@nvidia.com> <1325702378-20863-5-git-send-email-swarren@nvidia.com> <20120105131736.GC4641@page> <74CDBE0F657A3D45AFBB94109FB122FF17761F1683@HQMAIL01.nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF17761F1683-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stephen Warren Cc: Jamie Iles , Olof Johansson , Colin Cross , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org On Thu, Jan 05, 2012 at 08:47:15AM -0800, Stephen Warren wrote: > Jamie Iles wrote at Thursday, January 05, 2012 6:18 AM: > > On Wed, Jan 04, 2012 at 11:39:37AM -0700, Stephen Warren wrote: > > > Enhance the driver to dynamically allocate the base IRQ number, and > > > create an IRQ domain for itself. The use of an IRQ domain ensures that > > > any device tree node interrupts properties are correctly parsed. > ... > > > diff --git a/Documentation/devicetree/bindings/gpio/gpio_nvidia.txt > ... > > > +- #interrupt-cells : Should be 2. > > > + The first cell is the GPIO number. > > > + The second cell is used to specify flags: > > > + bits[3:0] trigger type and level flags: > > > + 1 = low-to-high edge triggered. > > > + 2 = high-to-low edge triggered. > > > + 4 = active high level-sensitive. > > > + 8 = active low level-sensitive. > > > + Valid combinations are 1, 2, 3, 4, 8. > > > > It looks to me like the tegra gpio driver can do IRQ_TYPE_EDGE_BOTH so I > > would expect 12 to be a valid combination too no? > > I believe EDGE_BOTH is 3 (OR of edge low and edge high) Doh! Yes, you're quite right. Sorry for the noise! Jamie