From: Grant Likely <grant.likely@secretlab.ca>
To: Benoit Cousson <b-cousson@ti.com>
Cc: rob.herring@calxeda.com, tony@atomide.com,
devicetree-discuss@lists.ozlabs.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/5] arm/dts: OMAP4: Update DTS file with new GIC bindings
Date: Fri, 6 Jan 2012 14:15:58 -0700 [thread overview]
Message-ID: <20120106211558.GA7457@ponder.secretlab.ca> (raw)
In-Reply-To: <1324388398-2683-2-git-send-email-b-cousson@ti.com>
On Tue, Dec 20, 2011 at 02:39:54PM +0100, Benoit Cousson wrote:
> The GIC binding was updated in 3.2 and expect 3 interrupt-cells.
> - Update the #interrupt-cells
> - interrupt-parent seems to be needed as well for the top level GIC
Hmmm... it shouldn't be. If it is then it is a bug.
g.
>
> Signed-off-by: Benoit Cousson <b-cousson@ti.com>
> Cc: Rob Herring <rob.herring@calxeda.com>
> ---
> arch/arm/boot/dts/omap4.dtsi | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
> index 4c61c82..bede009 100644
> --- a/arch/arm/boot/dts/omap4.dtsi
> +++ b/arch/arm/boot/dts/omap4.dtsi
> @@ -95,7 +95,8 @@
> gic: interrupt-controller@48241000 {
> compatible = "arm,cortex-a9-gic";
> interrupt-controller;
> - #interrupt-cells = <1>;
> + interrupt-parent;
> + #interrupt-cells = <3>;
> reg = <0x48241000 0x1000>,
> <0x48240100 0x0100>;
> };
> --
> 1.7.0.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2012-01-06 21:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-20 13:39 [PATCH v2 0/5] ARM: OMAP2+: Interrupt controllers adaptation to DT Benoit Cousson
2011-12-20 13:39 ` [PATCH v2 1/5] arm/dts: OMAP4: Update DTS file with new GIC bindings Benoit Cousson
2012-01-06 21:15 ` Grant Likely [this message]
2012-01-06 21:30 ` Rob Herring
2012-01-09 13:31 ` Cousson, Benoit
2011-12-20 13:39 ` [PATCH v2 2/5] ARM: OMAP2/3: intc: Add irqdomain support Benoit Cousson
2012-01-06 21:22 ` Grant Likely
2012-01-09 9:56 ` Cousson, Benoit
2011-12-20 13:39 ` [PATCH v2 3/5] ARM: OMAP2/3: intc: Add DT support for TI interrupt controller Benoit Cousson
2012-01-06 21:24 ` Grant Likely
2011-12-20 13:39 ` [PATCH v2 4/5] arm/dts: OMAP3: Add interrupt-controller bindings for INTC Benoit Cousson
2012-01-06 21:24 ` Grant Likely
2012-01-13 6:14 ` Hiremath, Vaibhav
2012-01-13 11:03 ` Cousson, Benoit
2012-01-13 12:31 ` Hiremath, Vaibhav
2012-01-13 13:01 ` Cousson, Benoit
2012-01-13 14:27 ` Hiremath, Vaibhav
2011-12-20 13:39 ` [PATCH v2 5/5] ARM: OMAP2+: board-generic: Use of_irq_init API Benoit Cousson
2012-01-06 21:25 ` Grant Likely
2011-12-23 9:46 ` [PATCH v2 0/5] ARM: OMAP2+: Interrupt controllers adaptation to DT Cousson, Benoit
2012-01-06 16:38 ` Cousson, Benoit
2012-01-06 18:56 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120106211558.GA7457@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=b-cousson@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).