From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Thomas Abraham <thomas.abraham@linaro.org>
Cc: linux-fbdev@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
kgene.kim@samsung.com, FlorianSchandinat@gmx.de,
jg1.han@samsung.com, rob.herring@calxeda.com,
grant.likely@secretlab.ca, linux-samsung-soc@vger.kernel.org,
patches@linaro.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] video: s3c-fb: Add device tree support
Date: Tue, 10 Jan 2012 04:52:20 +0000 [thread overview]
Message-ID: <20120110045219.GA5433@sirena.org.uk> (raw)
In-Reply-To: <1326139307-25112-1-git-send-email-thomas.abraham@linaro.org>
On Tue, Jan 10, 2012 at 01:31:47AM +0530, Thomas Abraham wrote:
> +Required properties:
> +- gpios: The gpios used to interface with the external LCD panel.
This isn't terribly informative for the user - which GPIOs and in what
order are they specified? Looking at the code it looks like pin mux
configuration so just some wording saying it's a list of pins to be used
for the framebuffer function.
next prev parent reply other threads:[~2012-01-10 4:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 20:01 [PATCH] video: s3c-fb: Add device tree support Thomas Abraham
2012-01-10 4:52 ` Mark Brown [this message]
[not found] ` <20120110045219.GA5433-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2012-01-11 11:04 ` Thomas Abraham
2012-01-11 17:40 ` Mark Brown
2012-01-11 9:16 ` Jingoo Han
2012-01-11 11:11 ` Thomas Abraham
2012-01-13 21:03 ` Sylwester Nawrocki
2012-01-13 21:30 ` Sylwester Nawrocki
2012-01-17 5:14 ` Thomas Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120110045219.GA5433@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=FlorianSchandinat@gmx.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=jg1.han@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=rob.herring@calxeda.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).