From: Jamie Iles <jamie-wmLquQDDieKakBO8gow8eQ@public.gmane.org>
To: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: RFC: option to toggle dtc checks on and off
Date: Wed, 11 Jan 2012 13:38:12 +0000 [thread overview]
Message-ID: <20120111133812.GJ3226@page> (raw)
In-Reply-To: <20120111121941.GI4935-MK4v0fQdeXQXU02nzanrWNbf9cGiqdzd@public.gmane.org>
On Wed, Jan 11, 2012 at 11:19:41PM +1100, David Gibson wrote:
> On Mon, Jan 09, 2012 at 08:07:30AM -0600, Jon Loeliger wrote:
> > > Jon, I was hoping I'd get some comment on this patch eventually.
> >
> > Sorry/ .
> >
> > > On Fri, Oct 28, 2011 at 04:15:25PM +1100, David Gibson wrote:
> > > > Here is a draft patch which adds a -C option to dtc, allowing
> > > > individual semantic checks to be turned on and off. It also allows
> > > > indivudual checks to be set as triggering either warnings or errors.
> >
> > Turning checks on and off: good.
> >
> > > > I have a couple of concerns about it in its present form. First, the
> > > > current syntax is that "-C -checkname" disables a check, "-C
> > > > checkname" turns a check on as a warning and "-C +checkname" turns it
> > > > on as an error. I'm not convinced this is a great syntax.
> >
> > Yeah, that's sub-obtimal.
> > What about using something like "-E checkname" and "-W checkname"?
>
> Yeah, I though of that too. Can't remeber why I didn't go that way.
> Gets a bit weird if you specify both -E foo and -W foo, but "last one
> wins" is probably still a reasonable way of deciding that. Any
> thoughts for an option to turn a check off completely?
How about the way that GCC handles warnings: -Wcheckname to enable,
-Wno-checkname to disable?
Jamie
next prev parent reply other threads:[~2012-01-11 13:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-28 5:15 RFC: option to toggle dtc checks on and off David Gibson
[not found] ` <20111028051525.GA7215-MK4v0fQdeXQXU02nzanrWNbf9cGiqdzd@public.gmane.org>
2012-01-09 2:41 ` David Gibson
[not found] ` <20120109024129.GH5628-MK4v0fQdeXQXU02nzanrWNbf9cGiqdzd@public.gmane.org>
2012-01-09 14:07 ` Jon Loeliger
[not found] ` <E1RkFso-00007g-Ue-CYoMK+44s/E@public.gmane.org>
2012-01-11 12:19 ` David Gibson
[not found] ` <20120111121941.GI4935-MK4v0fQdeXQXU02nzanrWNbf9cGiqdzd@public.gmane.org>
2012-01-11 13:38 ` Jamie Iles [this message]
2012-01-12 3:17 ` David Gibson
[not found] ` <20120112031714.GQ4935-MK4v0fQdeXQXU02nzanrWNbf9cGiqdzd@public.gmane.org>
2012-01-12 10:14 ` Jamie Iles
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120111133812.GJ3226@page \
--to=jamie-wmlquqddiekakbo8gow8eq@public.gmane.org \
--cc=david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).