From: Jamie Iles <jamie-wmLquQDDieKakBO8gow8eQ@public.gmane.org>
To: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
Subject: Re: [PATCH] irqdomain: include linux/bug.h for WARN_ON()
Date: Thu, 12 Jan 2012 14:41:26 +0000 [thread overview]
Message-ID: <20120112144126.GT3226@page> (raw)
In-Reply-To: <4F0EEFA0.7030808-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Thu, Jan 12, 2012 at 08:35:12AM -0600, Rob Herring wrote:
> Jamie,
>
> On 12/19/2011 04:22 PM, Jamie Iles wrote:
> > Commit 6d274309d (irq: support domains with non-zero hwirq base)
> > introduced a WARN_ON() for an invalid hwirq in irq_domain_to_irq() but
> > doesn't include linux/bug.h resulting in:
> >
> > include/linux/irqdomain.h: In function 'irq_domain_to_irq':
> > include/linux/irqdomain.h:78:2: error: implicit declaration of function 'WARN_ON'
> >
> > if it isn't implicitly pulled in before.
> >
>
> Considering major irqdomain changes are coming, is this really needed?
> Nothing is currently broken, right?
I think it's still worth applying though - if any of the new irqdomain
work still uses WARN()/BUG() and friends then it'll be required, and it
is possible that an existing platform with a different configuration
_could_ run into this.
I'll leave it up to you though.
Jamie
prev parent reply other threads:[~2012-01-12 14:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-19 22:22 [PATCH] irqdomain: include linux/bug.h for WARN_ON() Jamie Iles
[not found] ` <1324333357-3357-1-git-send-email-jamie-wmLquQDDieKakBO8gow8eQ@public.gmane.org>
2011-12-30 20:00 ` Jamie Iles
2011-12-30 20:13 ` Rob Herring
2012-01-12 14:35 ` Rob Herring
[not found] ` <4F0EEFA0.7030808-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-01-12 14:41 ` Jamie Iles [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120112144126.GT3226@page \
--to=jamie-wmlquqddiekakbo8gow8eq@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).