* [PATCH] irqdomain: include linux/bug.h for WARN_ON()
@ 2011-12-19 22:22 Jamie Iles
[not found] ` <1324333357-3357-1-git-send-email-jamie-wmLquQDDieKakBO8gow8eQ@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Jamie Iles @ 2011-12-19 22:22 UTC (permalink / raw)
To: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ; +Cc: Thomas Gleixner, Rob Herring
Commit 6d274309d (irq: support domains with non-zero hwirq base)
introduced a WARN_ON() for an invalid hwirq in irq_domain_to_irq() but
doesn't include linux/bug.h resulting in:
include/linux/irqdomain.h: In function 'irq_domain_to_irq':
include/linux/irqdomain.h:78:2: error: implicit declaration of function 'WARN_ON'
if it isn't implicitly pulled in before.
Cc: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
Cc: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Cc: Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
Signed-off-by: Jamie Iles <jamie-wmLquQDDieKakBO8gow8eQ@public.gmane.org>
---
include/linux/irqdomain.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/linux/irqdomain.h b/include/linux/irqdomain.h
index fd9815b..0c17b4b 100644
--- a/include/linux/irqdomain.h
+++ b/include/linux/irqdomain.h
@@ -15,6 +15,7 @@
#ifndef _LINUX_IRQDOMAIN_H
#define _LINUX_IRQDOMAIN_H
+#include <linux/bug.h>
#include <linux/mod_devicetable.h>
#ifdef CONFIG_IRQ_DOMAIN
--
1.7.5.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] irqdomain: include linux/bug.h for WARN_ON()
[not found] ` <1324333357-3357-1-git-send-email-jamie-wmLquQDDieKakBO8gow8eQ@public.gmane.org>
@ 2011-12-30 20:00 ` Jamie Iles
2011-12-30 20:13 ` Rob Herring
2012-01-12 14:35 ` Rob Herring
1 sibling, 1 reply; 5+ messages in thread
From: Jamie Iles @ 2011-12-30 20:00 UTC (permalink / raw)
To: Jamie Iles
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ, Thomas Gleixner,
Rob Herring
On Mon, Dec 19, 2011 at 10:22:37PM +0000, Jamie Iles wrote:
> Commit 6d274309d (irq: support domains with non-zero hwirq base)
> introduced a WARN_ON() for an invalid hwirq in irq_domain_to_irq() but
> doesn't include linux/bug.h resulting in:
>
> include/linux/irqdomain.h: In function 'irq_domain_to_irq':
> include/linux/irqdomain.h:78:2: error: implicit declaration of function 'WARN_ON'
>
> if it isn't implicitly pulled in before.
>
> Cc: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
> Cc: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
> Cc: Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
> Signed-off-by: Jamie Iles <jamie-wmLquQDDieKakBO8gow8eQ@public.gmane.org>
ping?
Jamie
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] irqdomain: include linux/bug.h for WARN_ON()
2011-12-30 20:00 ` Jamie Iles
@ 2011-12-30 20:13 ` Rob Herring
0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2011-12-30 20:13 UTC (permalink / raw)
To: Jamie Iles; +Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ, Thomas Gleixner
On 12/30/2011 02:00 PM, Jamie Iles wrote:
> On Mon, Dec 19, 2011 at 10:22:37PM +0000, Jamie Iles wrote:
>> Commit 6d274309d (irq: support domains with non-zero hwirq base)
>> introduced a WARN_ON() for an invalid hwirq in irq_domain_to_irq() but
>> doesn't include linux/bug.h resulting in:
>>
>> include/linux/irqdomain.h: In function 'irq_domain_to_irq':
>> include/linux/irqdomain.h:78:2: error: implicit declaration of function 'WARN_ON'
>>
>> if it isn't implicitly pulled in before.
>>
>> Cc: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
>> Cc: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
>> Cc: Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
>> Signed-off-by: Jamie Iles <jamie-wmLquQDDieKakBO8gow8eQ@public.gmane.org>
>
Applied for 3.3.
Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] irqdomain: include linux/bug.h for WARN_ON()
[not found] ` <1324333357-3357-1-git-send-email-jamie-wmLquQDDieKakBO8gow8eQ@public.gmane.org>
2011-12-30 20:00 ` Jamie Iles
@ 2012-01-12 14:35 ` Rob Herring
[not found] ` <4F0EEFA0.7030808-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
1 sibling, 1 reply; 5+ messages in thread
From: Rob Herring @ 2012-01-12 14:35 UTC (permalink / raw)
To: Jamie Iles; +Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ, Thomas Gleixner
Jamie,
On 12/19/2011 04:22 PM, Jamie Iles wrote:
> Commit 6d274309d (irq: support domains with non-zero hwirq base)
> introduced a WARN_ON() for an invalid hwirq in irq_domain_to_irq() but
> doesn't include linux/bug.h resulting in:
>
> include/linux/irqdomain.h: In function 'irq_domain_to_irq':
> include/linux/irqdomain.h:78:2: error: implicit declaration of function 'WARN_ON'
>
> if it isn't implicitly pulled in before.
>
Considering major irqdomain changes are coming, is this really needed?
Nothing is currently broken, right?
Rob
> Cc: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
> Cc: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
> Cc: Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
> Signed-off-by: Jamie Iles <jamie-wmLquQDDieKakBO8gow8eQ@public.gmane.org>
> ---
> include/linux/irqdomain.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/irqdomain.h b/include/linux/irqdomain.h
> index fd9815b..0c17b4b 100644
> --- a/include/linux/irqdomain.h
> +++ b/include/linux/irqdomain.h
> @@ -15,6 +15,7 @@
> #ifndef _LINUX_IRQDOMAIN_H
> #define _LINUX_IRQDOMAIN_H
>
> +#include <linux/bug.h>
> #include <linux/mod_devicetable.h>
>
> #ifdef CONFIG_IRQ_DOMAIN
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] irqdomain: include linux/bug.h for WARN_ON()
[not found] ` <4F0EEFA0.7030808-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2012-01-12 14:41 ` Jamie Iles
0 siblings, 0 replies; 5+ messages in thread
From: Jamie Iles @ 2012-01-12 14:41 UTC (permalink / raw)
To: Rob Herring; +Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ, Thomas Gleixner
On Thu, Jan 12, 2012 at 08:35:12AM -0600, Rob Herring wrote:
> Jamie,
>
> On 12/19/2011 04:22 PM, Jamie Iles wrote:
> > Commit 6d274309d (irq: support domains with non-zero hwirq base)
> > introduced a WARN_ON() for an invalid hwirq in irq_domain_to_irq() but
> > doesn't include linux/bug.h resulting in:
> >
> > include/linux/irqdomain.h: In function 'irq_domain_to_irq':
> > include/linux/irqdomain.h:78:2: error: implicit declaration of function 'WARN_ON'
> >
> > if it isn't implicitly pulled in before.
> >
>
> Considering major irqdomain changes are coming, is this really needed?
> Nothing is currently broken, right?
I think it's still worth applying though - if any of the new irqdomain
work still uses WARN()/BUG() and friends then it'll be required, and it
is possible that an existing platform with a different configuration
_could_ run into this.
I'll leave it up to you though.
Jamie
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-01-12 14:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-19 22:22 [PATCH] irqdomain: include linux/bug.h for WARN_ON() Jamie Iles
[not found] ` <1324333357-3357-1-git-send-email-jamie-wmLquQDDieKakBO8gow8eQ@public.gmane.org>
2011-12-30 20:00 ` Jamie Iles
2011-12-30 20:13 ` Rob Herring
2012-01-12 14:35 ` Rob Herring
[not found] ` <4F0EEFA0.7030808-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-01-12 14:41 ` Jamie Iles
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).