* [PATCH] USB: EHCI: Don't use NO_IRQ in xilinx ehci driver
@ 2012-01-12 8:26 Michal Simek
[not found] ` <1326356777-24135-1-git-send-email-monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Michal Simek @ 2012-01-12 8:26 UTC (permalink / raw)
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ, Greg Kroah-Hartman,
Alan Stern
Drivers shouldn't use NO_IRQ. This driver is used
by Microblaze and PPC. PPC defines NO_IRQ as 0
and Microblaze has removed it.
Signed-off-by: Michal Simek <monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org>
CC: Alan Stern <stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>
CC: Greg Kroah-Hartman <gregkh-l3A5Bk7waGM@public.gmane.org>
CC: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
CC: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
CC: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
---
drivers/usb/host/ehci-xilinx-of.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/host/ehci-xilinx-of.c b/drivers/usb/host/ehci-xilinx-of.c
index 32793ce..9c2cc46 100644
--- a/drivers/usb/host/ehci-xilinx-of.c
+++ b/drivers/usb/host/ehci-xilinx-of.c
@@ -183,7 +183,7 @@ static int __devinit ehci_hcd_xilinx_of_probe(struct platform_device *op)
}
irq = irq_of_parse_and_map(dn, 0);
- if (irq == NO_IRQ) {
+ if (!irq) {
printk(KERN_ERR "%s: irq_of_parse_and_map failed\n", __FILE__);
rv = -EBUSY;
goto err_irq;
--
1.7.5.4
^ permalink raw reply related [flat|nested] 4+ messages in thread[parent not found: <1326356777-24135-1-git-send-email-monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org>]
* Re: [PATCH] USB: EHCI: Don't use NO_IRQ in xilinx ehci driver [not found] ` <1326356777-24135-1-git-send-email-monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org> @ 2012-01-12 15:56 ` Alan Stern [not found] ` <Pine.LNX.4.44L0.1201121055370.1384-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org> 0 siblings, 1 reply; 4+ messages in thread From: Alan Stern @ 2012-01-12 15:56 UTC (permalink / raw) To: Michal Simek Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA, Greg Kroah-Hartman, Grant Likely, linux-usb-u79uwXL29TY76Z2rM5mHXA, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ On Thu, 12 Jan 2012, Michal Simek wrote: > Drivers shouldn't use NO_IRQ. This driver is used > by Microblaze and PPC. PPC defines NO_IRQ as 0 > and Microblaze has removed it. > > Signed-off-by: Michal Simek <monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org> > CC: Alan Stern <stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org> > CC: Greg Kroah-Hartman <gregkh-l3A5Bk7waGM@public.gmane.org> > CC: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> > CC: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > CC: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org > --- > drivers/usb/host/ehci-xilinx-of.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/usb/host/ehci-xilinx-of.c b/drivers/usb/host/ehci-xilinx-of.c > index 32793ce..9c2cc46 100644 > --- a/drivers/usb/host/ehci-xilinx-of.c > +++ b/drivers/usb/host/ehci-xilinx-of.c > @@ -183,7 +183,7 @@ static int __devinit ehci_hcd_xilinx_of_probe(struct platform_device *op) > } > > irq = irq_of_parse_and_map(dn, 0); > - if (irq == NO_IRQ) { > + if (!irq) { > printk(KERN_ERR "%s: irq_of_parse_and_map failed\n", __FILE__); > rv = -EBUSY; > goto err_irq; Acked-by: Alan Stern <stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org> -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <Pine.LNX.4.44L0.1201121055370.1384-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>]
* Re: [PATCH] USB: EHCI: Don't use NO_IRQ in xilinx ehci driver [not found] ` <Pine.LNX.4.44L0.1201121055370.1384-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org> @ 2012-01-13 11:27 ` Michal Simek [not found] ` <4F10151A.8000209-g5w7nrANp4BDPfheJLI6IQ@public.gmane.org> 0 siblings, 1 reply; 4+ messages in thread From: Michal Simek @ 2012-01-13 11:27 UTC (permalink / raw) To: Grant Likely Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ, Greg Kroah-Hartman, linux-kernel-u79uwXL29TY76Z2rM5mHXA, Alan Stern Alan Stern wrote: > On Thu, 12 Jan 2012, Michal Simek wrote: > >> Drivers shouldn't use NO_IRQ. This driver is used >> by Microblaze and PPC. PPC defines NO_IRQ as 0 >> and Microblaze has removed it. >> >> Signed-off-by: Michal Simek <monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org> >> CC: Alan Stern <stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org> >> CC: Greg Kroah-Hartman <gregkh-l3A5Bk7waGM@public.gmane.org> >> CC: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> >> CC: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> CC: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org >> --- >> drivers/usb/host/ehci-xilinx-of.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/usb/host/ehci-xilinx-of.c b/drivers/usb/host/ehci-xilinx-of.c >> index 32793ce..9c2cc46 100644 >> --- a/drivers/usb/host/ehci-xilinx-of.c >> +++ b/drivers/usb/host/ehci-xilinx-of.c >> @@ -183,7 +183,7 @@ static int __devinit ehci_hcd_xilinx_of_probe(struct platform_device *op) >> } >> >> irq = irq_of_parse_and_map(dn, 0); >> - if (irq == NO_IRQ) { >> + if (!irq) { >> printk(KERN_ERR "%s: irq_of_parse_and_map failed\n", __FILE__); >> rv = -EBUSY; >> goto err_irq; > > Acked-by: Alan Stern <stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org> Thanks Alan. I have seen that Grant sent the same patch to lkml too. Here is the thread: http://lkml.org/lkml/2012/1/11/342 Grant: How fast do you think you are able to merge your patches? Currently I have remove NO_IRQ from Microblaze and we use this driver which means that driver compilation failed right now. That's why I would like to fix asap. Thanks, Michal -- Michal Simek, Ing. (M.Eng) PetaLogix - Linux Solutions for a Reconfigurable World w: www.petalogix.com p: +61-7-30090663,+42-0-721842854 f: +61-7-30090663 ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <4F10151A.8000209-g5w7nrANp4BDPfheJLI6IQ@public.gmane.org>]
* Re: [PATCH] USB: EHCI: Don't use NO_IRQ in xilinx ehci driver [not found] ` <4F10151A.8000209-g5w7nrANp4BDPfheJLI6IQ@public.gmane.org> @ 2012-01-13 18:39 ` Grant Likely 0 siblings, 0 replies; 4+ messages in thread From: Grant Likely @ 2012-01-13 18:39 UTC (permalink / raw) To: Michal Simek Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ, Greg Kroah-Hartman, linux-kernel-u79uwXL29TY76Z2rM5mHXA, Alan Stern On Fri, Jan 13, 2012 at 12:27:22PM +0100, Michal Simek wrote: > Alan Stern wrote: > >On Thu, 12 Jan 2012, Michal Simek wrote: > > > >>Drivers shouldn't use NO_IRQ. This driver is used > >>by Microblaze and PPC. PPC defines NO_IRQ as 0 > >>and Microblaze has removed it. > >> > >>Signed-off-by: Michal Simek <monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org> > >>CC: Alan Stern <stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org> > >>CC: Greg Kroah-Hartman <gregkh-l3A5Bk7waGM@public.gmane.org> > >>CC: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> > >>CC: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > >>CC: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org > >>--- > >> drivers/usb/host/ehci-xilinx-of.c | 2 +- > >> 1 files changed, 1 insertions(+), 1 deletions(-) > >> > >>diff --git a/drivers/usb/host/ehci-xilinx-of.c b/drivers/usb/host/ehci-xilinx-of.c > >>index 32793ce..9c2cc46 100644 > >>--- a/drivers/usb/host/ehci-xilinx-of.c > >>+++ b/drivers/usb/host/ehci-xilinx-of.c > >>@@ -183,7 +183,7 @@ static int __devinit ehci_hcd_xilinx_of_probe(struct platform_device *op) > >> } > >> irq = irq_of_parse_and_map(dn, 0); > >>- if (irq == NO_IRQ) { > >>+ if (!irq) { > >> printk(KERN_ERR "%s: irq_of_parse_and_map failed\n", __FILE__); > >> rv = -EBUSY; > >> goto err_irq; > > > >Acked-by: Alan Stern <stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org> > > Thanks Alan. > > I have seen that Grant sent the same patch to lkml too. > Here is the thread: http://lkml.org/lkml/2012/1/11/342 > > Grant: How fast do you think you are able to merge your patches? Ignore my patch. It won't go in until 3.4 g. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-01-13 18:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-12 8:26 [PATCH] USB: EHCI: Don't use NO_IRQ in xilinx ehci driver Michal Simek
[not found] ` <1326356777-24135-1-git-send-email-monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org>
2012-01-12 15:56 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1201121055370.1384-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-01-13 11:27 ` Michal Simek
[not found] ` <4F10151A.8000209-g5w7nrANp4BDPfheJLI6IQ@public.gmane.org>
2012-01-13 18:39 ` Grant Likely
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).