From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH 20/31] ARM: amba: versatile: get rid of private platform amba_device initializer Date: Tue, 24 Jan 2012 15:06:59 +0000 Message-ID: <20120124150659.GK19798@mudshark.cambridge.arm.com> References: <20120120092207.GD1068@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org To: Russell King - ARM Linux Cc: "linux-arm-kernel@lists.infradead.org" , "devicetree-discuss@lists.ozlabs.org" , "linux-mmc@vger.kernel.org" , "linux-omap@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" , STEricsson List-Id: devicetree@vger.kernel.org On Fri, Jan 20, 2012 at 09:29:10AM +0000, Russell King - ARM Linux wrote: > Signed-off-by: Russell King > --- > arch/arm/mach-versatile/core.c | 36 ++++++++++++++++---------------- > arch/arm/mach-versatile/core.h | 20 ++++------------- > arch/arm/mach-versatile/versatile_pb.c | 10 ++++---- > 3 files changed, 28 insertions(+), 38 deletions(-) This seems happy enough on a Versatile AB926, although I do get spurious IRQs from the ethernet chip: eth0: spurious interrupt (mask = 0xb3) This doesn't seem to be the fault of this patch though; I suspect it's related to the recent VIC changes and removal of MULTI_IRQ_HANDLER (especially since the ethernet interrupts lives on the secondary controller). So for this patch: Tested-by: Will Deacon I'll investigate the other problem separately. Will