devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: devicetree: Add .dtb files to arch/arm/boot/.gitignore
@ 2012-01-30 16:15 Dave Martin
       [not found] ` <1327940122-7674-1-git-send-email-dave.martin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
  0 siblings, 1 reply; 6+ messages in thread
From: Dave Martin @ 2012-01-30 16:15 UTC (permalink / raw)
  To: patches-lFZ/pmaqli7XmaaqVzeoHQ,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ

Compiled device tree blobs shouldn't be committed in the kernel
tree, so ideally git should ignore them.

This patch will enable ignoring of any .dtb files which appear in
arch/arm/boot/

Signed-off-by: Dave Martin <dave.martin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---
 arch/arm/boot/.gitignore |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/.gitignore b/arch/arm/boot/.gitignore
index ce1c5ff..3c79f85 100644
--- a/arch/arm/boot/.gitignore
+++ b/arch/arm/boot/.gitignore
@@ -3,3 +3,4 @@ zImage
 xipImage
 bootpImage
 uImage
+*.dtb
-- 
1.7.4.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] ARM: devicetree: Add .dtb files to arch/arm/boot/.gitignore
@ 2012-01-30 17:46 Dave Martin
       [not found] ` <1327945574-7977-1-git-send-email-dave.martin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
  0 siblings, 1 reply; 6+ messages in thread
From: Dave Martin @ 2012-01-30 17:46 UTC (permalink / raw)
  To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ
  Cc: patches-QSEj5FYQhm4dnm+yROfE0A

Compiled device tree blobs shouldn't be committed in the kernel
tree, so ideally git should ignore them.

This patch will enable ignoring of any .dtb files which appear in
arch/arm/boot/

Signed-off-by: Dave Martin <dave.martin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---
 arch/arm/boot/.gitignore |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/.gitignore b/arch/arm/boot/.gitignore
index ce1c5ff..3c79f85 100644
--- a/arch/arm/boot/.gitignore
+++ b/arch/arm/boot/.gitignore
@@ -3,3 +3,4 @@ zImage
 xipImage
 bootpImage
 uImage
+*.dtb
-- 
1.7.4.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: devicetree: Add .dtb files to arch/arm/boot/.gitignore
       [not found] ` <1327940122-7674-1-git-send-email-dave.martin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
@ 2012-01-30 18:47   ` Grant Likely
  0 siblings, 0 replies; 6+ messages in thread
From: Grant Likely @ 2012-01-30 18:47 UTC (permalink / raw)
  To: Dave Martin
  Cc: patches-lFZ/pmaqli7XmaaqVzeoHQ,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ

On Mon, Jan 30, 2012 at 04:15:22PM +0000, Dave Martin wrote:
> Compiled device tree blobs shouldn't be committed in the kernel
> tree, so ideally git should ignore them.
> 
> This patch will enable ignoring of any .dtb files which appear in
> arch/arm/boot/
> 
> Signed-off-by: Dave Martin <dave.martin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

Applied, thanks.

g.

> ---
>  arch/arm/boot/.gitignore |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/boot/.gitignore b/arch/arm/boot/.gitignore
> index ce1c5ff..3c79f85 100644
> --- a/arch/arm/boot/.gitignore
> +++ b/arch/arm/boot/.gitignore
> @@ -3,3 +3,4 @@ zImage
>  xipImage
>  bootpImage
>  uImage
> +*.dtb
> -- 
> 1.7.4.1
> 
> _______________________________________________
> devicetree-discuss mailing list
> devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
> https://lists.ozlabs.org/listinfo/devicetree-discuss

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: devicetree: Add .dtb files to arch/arm/boot/.gitignore
       [not found] ` <1327945574-7977-1-git-send-email-dave.martin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
@ 2012-01-31  3:20   ` Shawn Guo
       [not found]     ` <20120131032022.GC24681-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
  0 siblings, 1 reply; 6+ messages in thread
From: Shawn Guo @ 2012-01-31  3:20 UTC (permalink / raw)
  To: Dave Martin
  Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	patches-QSEj5FYQhm4dnm+yROfE0A

On Mon, Jan 30, 2012 at 05:46:14PM +0000, Dave Martin wrote:
> Compiled device tree blobs shouldn't be committed in the kernel
> tree, so ideally git should ignore them.
> 
> This patch will enable ignoring of any .dtb files which appear in
> arch/arm/boot/
> 
> Signed-off-by: Dave Martin <dave.martin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

Acked-by: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

I added my ack tag on the same patch below, but it died in the end?

http://comments.gmane.org/gmane.linux.ports.arm.kernel/144097

Regards,
Shawn

> ---
>  arch/arm/boot/.gitignore |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/boot/.gitignore b/arch/arm/boot/.gitignore
> index ce1c5ff..3c79f85 100644
> --- a/arch/arm/boot/.gitignore
> +++ b/arch/arm/boot/.gitignore
> @@ -3,3 +3,4 @@ zImage
>  xipImage
>  bootpImage
>  uImage
> +*.dtb
> -- 
> 1.7.4.1

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: devicetree: Add .dtb files to arch/arm/boot/.gitignore
       [not found]     ` <20120131032022.GC24681-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
@ 2012-01-31 11:46       ` Dave Martin
       [not found]         ` <20120131114659.GE2085-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
  0 siblings, 1 reply; 6+ messages in thread
From: Dave Martin @ 2012-01-31 11:46 UTC (permalink / raw)
  To: Shawn Guo
  Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ,
	patches-QSEj5FYQhm4dnm+yROfE0A,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	Uwe Kleine-Konig

On Tue, Jan 31, 2012 at 11:20:24AM +0800, Shawn Guo wrote:
> On Mon, Jan 30, 2012 at 05:46:14PM +0000, Dave Martin wrote:
> > Compiled device tree blobs shouldn't be committed in the kernel
> > tree, so ideally git should ignore them.
> > 
> > This patch will enable ignoring of any .dtb files which appear in
> > arch/arm/boot/
> > 
> > Signed-off-by: Dave Martin <dave.martin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> 
> Acked-by: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> 
> I added my ack tag on the same patch below, but it died in the end?
> 
> http://comments.gmane.org/gmane.linux.ports.arm.kernel/144097

I don't mind too much which patch goes in -- do we care about whether
other .dtb files can be included in the kernel?


I would suggest that it is just plain wrong for _binary_ devicetree
blobs to appear in the kernel tree, since there is a readily usable
source form for the same thing (this isn't firmware)

Do we think that the '.dtb' filename extension might get used foro
something else?

Cheers
---Dave

> 
> Regards,
> Shawn
> 
> > ---
> >  arch/arm/boot/.gitignore |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/arm/boot/.gitignore b/arch/arm/boot/.gitignore
> > index ce1c5ff..3c79f85 100644
> > --- a/arch/arm/boot/.gitignore
> > +++ b/arch/arm/boot/.gitignore
> > @@ -3,3 +3,4 @@ zImage
> >  xipImage
> >  bootpImage
> >  uImage
> > +*.dtb
> > -- 
> > 1.7.4.1

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: devicetree: Add .dtb files to arch/arm/boot/.gitignore
       [not found]         ` <20120131114659.GE2085-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
@ 2012-01-31 11:52           ` Dave Martin
  0 siblings, 0 replies; 6+ messages in thread
From: Dave Martin @ 2012-01-31 11:52 UTC (permalink / raw)
  To: Shawn Guo
  Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ,
	patches-QSEj5FYQhm4dnm+yROfE0A,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	Uwe Kleine-Konig

On Tue, Jan 31, 2012 at 11:46:59AM +0000, Dave Martin wrote:
> On Tue, Jan 31, 2012 at 11:20:24AM +0800, Shawn Guo wrote:
> > On Mon, Jan 30, 2012 at 05:46:14PM +0000, Dave Martin wrote:
> > > Compiled device tree blobs shouldn't be committed in the kernel
> > > tree, so ideally git should ignore them.
> > > 
> > > This patch will enable ignoring of any .dtb files which appear in
> > > arch/arm/boot/
> > > 
> > > Signed-off-by: Dave Martin <dave.martin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> > 
> > Acked-by: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> > 
> > I added my ack tag on the same patch below, but it died in the end?
> > 
> > http://comments.gmane.org/gmane.linux.ports.arm.kernel/144097
> 
> I don't mind too much which patch goes in -- do we care about whether
> other .dtb files can be included in the kernel?
> 
> 
> I would suggest that it is just plain wrong for _binary_ devicetree
> blobs to appear in the kernel tree, since there is a readily usable
> source form for the same thing (this isn't firmware)
> 
> Do we think that the '.dtb' filename extension might get used foro
> something else?

Never mind, it looks like Grant merged my patch anyway.

Cheers
---Dave

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2012-01-31 11:52 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-30 17:46 [PATCH] ARM: devicetree: Add .dtb files to arch/arm/boot/.gitignore Dave Martin
     [not found] ` <1327945574-7977-1-git-send-email-dave.martin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-01-31  3:20   ` Shawn Guo
     [not found]     ` <20120131032022.GC24681-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2012-01-31 11:46       ` Dave Martin
     [not found]         ` <20120131114659.GE2085-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-01-31 11:52           ` Dave Martin
  -- strict thread matches above, loose matches on Subject: below --
2012-01-30 16:15 Dave Martin
     [not found] ` <1327940122-7674-1-git-send-email-dave.martin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-01-30 18:47   ` Grant Likely

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).