From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [RFC PATCH 4/7] ARM: davinci: net: davinci_emac: add OF support Date: Wed, 1 Feb 2012 17:19:55 -0700 Message-ID: <20120202001955.GG15343@ponder.secretlab.ca> References: <1327308967-8092-1-git-send-email-hs@denx.de> <1327308967-8092-5-git-send-email-hs@denx.de> <20120130202208.GW28397@ponder.secretlab.ca> <4F27D00F.4040807@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <4F27D00F.4040807-ynQEQJNshbs@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Heiko Schocher Cc: davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org, Wolfgang Denk , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Sekhar Nori , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Tue, Jan 31, 2012 at 12:27:11PM +0100, Heiko Schocher wrote: > Hello Grant, > > Grant Likely wrote: > > On Mon, Jan 23, 2012 at 09:56:04AM +0100, Heiko Schocher wrote: > >> add of support for the davinci_emac driver. > >> > >> Signed-off-by: Heiko Schocher > >> Cc: davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org > >> Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > >> Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org > >> Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > >> Cc: Grant Likely > >> Cc: Sekhar Nori > >> Cc: Wolfgang Denk > >> --- > >> .../bindings/arm/davinci/davinci_emac.txt | 46 ++++++++ > >> drivers/net/ethernet/ti/davinci_emac.c | 111 +++++++++++++++++++- > >> 2 files changed, 156 insertions(+), 1 deletions(-) > >> create mode 100644 Documentation/devicetree/bindings/arm/davinci/davinci_emac.txt > >> > >> diff --git a/Documentation/devicetree/bindings/arm/davinci/davinci_emac.txt b/Documentation/devicetree/bindings/arm/davinci/davinci_emac.txt > >> new file mode 100644 > >> index 0000000..4e5dc8d > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/arm/davinci/davinci_emac.txt > >> @@ -0,0 +1,46 @@ > >> +* Texas Instruments Davinci EMAC > >> + > >> +This file provides information, what the davice node > >> +for the davinci_emac interface contain. > >> + > >> +Required properties: > >> +- compatible: "ti,davinci-emac"; > >> +- reg: Offset and length of the register set for the device > >> +- ctrl_reg_offset: offset to control register > >> +- ctrl_mod_reg_offset: offset to control module register > >> +- ctrl_ram_offset: offset to control module ram > > > > Should these be explicit properties, or can they be discerned from the > > compatible string (which should include the hardware version; see > > below). > > Hmm.. I do not know all davinci SoCs ... maybe someone from TI > could answer this? But I think, we could discern this from > the compatible string. I prepare this for v2. Maybe it is Ok, > if I do this only for my hardwareversion and others add this, > if needed? (maybe the better approach, as I can code it, but > have no hw for testing it ... so it maybe is buggy) > > > Also, any custom properties that are specific to a binding really > > should include a vendor prefix ('ti,') to avoid namespace collisions > > with common bindings. > > Yep, is "ti,davinci-" ok? Also I should use dashes instead > underscores, right? Correct. > > >> +- hw_ram_addr: hardware ram addr > > > > Can this be added as a second tuple in the reg property? > > No, if I know this right, this is used for DMA, and also could be RAM. Not getting what you mean here. The second tuple could be omitted if there isn't a physical address for hardware ram.