From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH v3 00/25] irq_domain generalization and refinement Date: Sun, 5 Feb 2012 16:13:48 +0000 Message-ID: <20120205161348.GZ889@n2100.arm.linux.org.uk> References: <1327700179-17454-1-git-send-email-grant.likely@secretlab.ca> <20120204221748.GN14129@n2100.arm.linux.org.uk> <20120204223125.GO14129@n2100.arm.linux.org.uk> <20120205013853.GQ20333@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20120205013853.GQ20333-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Tony Lindgren Cc: Stephen Rothwell , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Milton Miller , Thomas Gleixner , linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Sat, Feb 04, 2012 at 05:38:53PM -0800, Tony Lindgren wrote: > * Russell King - ARM Linux [120204 14:00]: > > > > Actually, it turns out to be not that hard, because twl doesn't actually > > make use of the IRQ domain stuff: > > > > commit aeb5032b3f8b9ab69daa545777433fa94b3494c4 > > Author: Benoit Cousson > > AuthorDate: Mon Aug 29 16:20:23 2011 +0200 > > Commit: Samuel Ortiz > > CommitDate: Mon Jan 9 00:37:40 2012 +0100 > > > > mfd: twl-core: Add initial DT support for twl4030/twl6030 > > > > [grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org: Fix IRQ_DOMAIN dependency in kconfig] > > > > Adding any dependency - especially one which wouldn't be enabled - for > > a new feature which wasn't required before is going to break existing > > users, so this shouldn't have been done in the first place. > > > > A better fix to preserve existing users would've been as below - yes > > it means more ifdefs, but if irq domain is to remain a DT only thing > > then we're going to end up with _lots_ of this stuff. > > > > I'd much prefer to see irq domain become more widely available so it > > doesn't require these ifdefs everywhere. > > Your patch below looks like a correct fix to me to the problem > you and Grazvydas are seeing: > > Acked-by: Tony Lindgren It's not quite correct, because OMAP4 has issues in this area as well (which does select IRQ_DOMAIN but can be without OF.) The result is an oops from irq_domain_add() because domain->ops is NULL. The right solution is three fold: 1. Wrap the bits of code in CONFIG_IRQ_DOMAIN 2. Get rid of the #ifdef CONFIG_OF there, so the 'ops' member can be initialized. 3. Fix the OMAP vp code not to oops when voltdm->pmic is NULL which I have in my combined patch for fixing OMAP so far.