devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: David Brown <davidb-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: hex number case in dts files.
Date: Fri, 10 Feb 2012 12:25:38 +1100	[thread overview]
Message-ID: <20120210012538.GC10536@truffala.fritz.box> (raw)
In-Reply-To: <20120210002950.GA18408-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>

On Thu, Feb 09, 2012 at 04:29:50PM -0800, David Brown wrote:
> On Fri, Feb 10, 2012 at 11:19:21AM +1100, David Gibson wrote:
> > On Thu, Feb 09, 2012 at 12:20:33PM -0600, Rob Herring wrote:
> > > On 02/09/2012 12:04 PM, David Brown wrote:
> > > > I've noticed an inconsistency in the case of letters in hex constants
> > > > in various dts files.  The ones that are actually numbers probably
> > > > don't really matter, the but the node names are case sensitive
> > > > strings, and in some sense do matter.
> > > > 
> > > > I ask because some people I've spoken with internally seem to have
> > > > strong opinions about what case hex constants should be, and it'd be
> > > > nice to be able to have some guideline about this.  Historically, I've
> > > > always seen DT hex values in lowercase.
> > > > 
> > > 
> > > Lower case should be used for dts files.
> > 
> > Yes, the node names should always have the hex done in lower case.  I
> > have plans to put more checks in for how reg is encoded into node
> > names, but just need to get time.
> 
> What about number of digits?  Should a register at 0x42 be
> node@00000042 or node@42?  Again, I'm seeing both.

node@42

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

  parent reply	other threads:[~2012-02-10  1:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-09 18:04 hex number case in dts files David Brown
     [not found] ` <20120209180411.GA5654-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2012-02-09 18:20   ` Rob Herring
     [not found]     ` <4F340E71.7070004-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-02-10  0:19       ` David Gibson
     [not found]         ` <20120210001921.GA10536-MK4v0fQdeXQXU02nzanrWNbf9cGiqdzd@public.gmane.org>
2012-02-10  0:29           ` David Brown
     [not found]             ` <20120210002950.GA18408-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2012-02-10  1:25               ` David Gibson [this message]
2012-02-10 17:25               ` Segher Boessenkool

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120210012538.GC10536@truffala.fritz.box \
    --to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
    --cc=davidb-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).