From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Ryan Mallon <rmallon@gmail.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, rob.herring@calxeda.com,
grant.likely@secretlab.ca, avictor.za@gmail.com,
tglx@linutronix.de, plagnioj@jcrosoft.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/9] ARM: at91/snapper9260: move gpio_to_irq out of structure initialization
Date: Tue, 14 Feb 2012 09:48:35 +0000 [thread overview]
Message-ID: <20120214094835.GB13673@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <4F396C4C.9060108@gmail.com>
On Tue, Feb 14, 2012 at 07:02:20AM +1100, Ryan Mallon wrote:
> On 14/02/12 01:43, Nicolas Ferre wrote:
>
> > gpio_to_irq() implementation will be moved from a macro to a
> > plain function: we cannot use it in a structure initialization
> > anymore.
>
> What was the reason for the change? It was originally a macro for
> exactly this reason.
gpio_to_irq() is supposed to work not only for built-in GPIOs, but also
GPIOs provided by other devices. Having it as a definition which only
works for the SoC GPIOs is broken.
next prev parent reply other threads:[~2012-02-14 9:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-13 14:43 [PATCH 0/9] ARM: at91: irqdomain and device tree for AIC and GPIO Nicolas Ferre
[not found] ` <1329144189-4535-1-git-send-email-nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-02-13 14:43 ` [PATCH v5 1/9] ARM: at91/aic: add irq domain and device tree support Nicolas Ferre
2012-02-13 14:43 ` [PATCH 2/9] ARM: at91/snapper9260: move gpio_to_irq out of structure initialization Nicolas Ferre
2012-02-13 20:02 ` Ryan Mallon
2012-02-14 9:04 ` Nicolas Ferre
2012-02-14 9:48 ` Russell King - ARM Linux [this message]
2012-02-13 14:43 ` [PATCH 3/9] ARM/USB: at91/ohci-at91: remove the use of irq_to_gpio Nicolas Ferre
[not found] ` <fab15f7eaf6622e68e62bc3afa533b12f48ca27e.1329139662.git.nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-02-17 9:41 ` Nicolas Ferre
2012-02-17 16:59 ` Greg Kroah-Hartman
2012-02-13 14:43 ` [PATCH 4/9] ARM: at91/gpio: change comments and one variable name Nicolas Ferre
2012-02-13 14:43 ` [PATCH v5 5/9] ARM: at91/gpio: add irqdomain and DT support Nicolas Ferre
2012-02-13 14:43 ` [PATCH 6/9] ARM: at91/gpio: non-DT builds do not have gpio_chip.of_node field Nicolas Ferre
2012-02-13 14:43 ` [PATCH 7/9] ARM: at91/gpio: add .to_irq gpio_chip handler Nicolas Ferre
2012-02-13 14:43 ` [PATCH 8/9] ARM: at91/gpio: remove the static specification of gpio_chip.base Nicolas Ferre
2012-02-13 14:43 ` [PATCH 9/9] ARM: at91/board-dt: remove AIC irq domain from board file Nicolas Ferre
2012-02-13 22:10 ` [PATCH v5 1/9] ARM: at91/aic: add irq domain and device tree support Rob Herring
2012-02-14 10:24 ` Nicolas Ferre
2012-02-14 14:11 ` Rob Herring
[not found] ` <4F3A6B7B.9040406-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-02-17 9:26 ` Nicolas Ferre
2012-02-17 9:27 ` [PATCH] ARM: at91: AIC and GPIO IRQ device tree initilization Nicolas Ferre
[not found] ` <1329470878-14635-1-git-send-email-nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-02-21 10:06 ` Nicolas Ferre
[not found] ` <4F436C95.2040508-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-02-21 10:16 ` Russell King - ARM Linux
2012-02-21 14:07 ` Rob Herring
2012-02-22 9:07 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120214094835.GB13673@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=avictor.za@gmail.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
--cc=rmallon@gmail.com \
--cc=rob.herring@calxeda.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).