From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v3 00/10] Add PWM framework and device tree support. Date: Thu, 23 Feb 2012 08:29:19 +0100 Message-ID: <20120223072917.GA8621@avionic-0098.mockup.avionic-design.de> References: <1329923841-32017-1-git-send-email-thierry.reding@avionic-design.de> <201202221602.09116.arnd@arndb.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="82I3+IH0IqGh5yIs" Return-path: Content-Disposition: inline In-Reply-To: <201202221602.09116.arnd-r2nGTMty4D4@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arnd Bergmann Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Sascha Hauer , Matthias Kaehlcke , Kurt Van Dijck , Rob Herring , Grant Likely , Colin Cross , Olof Johansson , Richard Purdie , Mark Brown , Mitch Bradley , Mike Frysinger , Eric Miao , Lars-Peter Clausen , Ryan Mallon List-Id: devicetree@vger.kernel.org --82I3+IH0IqGh5yIs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable * Arnd Bergmann wrote: > On Wednesday 22 February 2012, Thierry Reding wrote: > > This patch series adds very rudimentary device-tree support for PWM > > devices. With all of these patches applied (plus one board-specific > > patch that is not included), I'm able to control the backlight on the > > device I'm working on using the sysfs interface provided by the pwm-bl > > driver and the backlight class. > >=20 > > This series is based on Sascha Hauer's series of patches[0] to add a > > generic PWM framework. The first patch in this series is taken from > > Sascha's branch, while the second patch enables each PWM chip to provide > > multiple PWM devices (the Blackfin and PXA drivers have been ported to > > the framework for reference). When this series is ready I think it would > > be best to merge patches 1 and 2. Currently a global namespace is still > > provided to keep backwards-compatibility with the legacy PWM API. In > > order to achieve this, the number of global PWM devices is limited to > > 1024. However, patch 2 introduces per-chip indexing of PWM devices in > > the core, so it should be easy to add an API to request a PWM device on > > a per-chip basis and get rid of the global namespace eventually. The > > device tree support code does not use the global namespace. >=20 > Hi Thierry, >=20 > I've just had a chance to look at your series and I think this looks > very good overall, great work! >=20 > I probably wouldn't bother merging patches 1 and 2 as you listed > in the TODO section, in order to keep the authorship of each > part obvious. Okay, no problem. Thierry --82I3+IH0IqGh5yIs Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAk9F6swACgkQZ+BJyKLjJp/ZZACbB7RuKMvkHYEeO8NFEDYTWm3P oB0AoKODU9W4MG8GrFMbnETXccRmxXFw =G32k -----END PGP SIGNATURE----- --82I3+IH0IqGh5yIs--