From: David Miller <davem@davemloft.net>
To: ddaney.cavm@gmail.com
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org,
devicetree-discuss@lists.ozlabs.org, grant.likely@secretlab.ca,
rob.herring@calxeda.com, linux-kernel@vger.kernel.org,
david.daney@cavium.com
Subject: Re: [PATCH v6 2/2] of: Make of_find_node_by_path() traverse /aliases for relative paths.
Date: Wed, 29 Feb 2012 15:36:33 -0500 (EST) [thread overview]
Message-ID: <20120229.153633.249570825230282737.davem@davemloft.net> (raw)
In-Reply-To: <1330543264-18103-3-git-send-email-ddaney.cavm@gmail.com>
From: David Daney <ddaney.cavm@gmail.com>
Date: Wed, 29 Feb 2012 11:21:04 -0800
> Currently all paths passed to of_find_node_by_path() must begin with a
> '/', indicating a full path to the desired node.
>
> Augment the look-up code so that if a path does *not* begin with '/',
> the path is used as the name of an /aliases property. The value of
> this alias is then used as the full node path to be found.
>
> Signed-off-by: David Daney <david.daney@cavium.com>
But as the caller you sure as hell know whether you have a "/"
prefixed name or not.
Why complicate an incredibly well designed and simple function for
something you can create another interface for?
next prev parent reply other threads:[~2012-02-29 20:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 19:21 [PATCH v6 0/2] of: Device Tree enhancements needed by MIPS/OCTEON David Daney
2012-02-29 19:21 ` [PATCH v6 1/2] of/lib: Allow scripts/dtc/libfdt to be used from kernel code David Daney
2012-02-29 19:21 ` [PATCH v6 2/2] of: Make of_find_node_by_path() traverse /aliases for relative paths David Daney
2012-02-29 20:36 ` David Miller [this message]
2012-02-29 21:34 ` David Daney
2012-02-29 22:18 ` David Daney
2012-03-09 1:33 ` Grant Likely
2012-03-09 17:59 ` David Daney
2012-03-09 18:00 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120229.153633.249570825230282737.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=david.daney@cavium.com \
--cc=ddaney.cavm@gmail.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).