From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Subject: Re: [PATCH 5/5 v2] ARM: kirkwood: convert orion-wdt to fdt. Date: Sat, 3 Mar 2012 18:05:11 -0500 Message-ID: <20120303230511.GS11986@titan.lakedaemon.net> References: <201203021832.34901.arnd@arndb.de> <20120303100853.GK7363@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20120303100853.GK7363-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Russell King - ARM Linux Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Sat, Mar 03, 2012 at 10:08:53AM +0000, Russell King - ARM Linux wrote: > On Fri, Mar 02, 2012 at 06:32:33PM +0000, Arnd Bergmann wrote: > > On Friday 02 March 2012, Jason Cooper wrote: > > > + wdt_reg = (void __iomem *)TIMER_VIRT_BASE; > > > + > > > + ret = of_address_to_resource(np, 0, &res); > > > + if (ret) { > > > + printk(KERN_ERR "invalid address\n"); > > > + return ret; > > > + } > > > + > > > + wdt_reg = ioremap(res.start, res.end - res.start); > > > + > > > > This will break non-dt uses because you overwrite the wdt_reg value. > > Don't also forget that "res.end - res.start" is also not correct, and > resource_size() should be used to prevent that kind of error. Russell, thanks for the review. I'll redo this one and resubmit my pull-request to Arnd. I assume that we don't won't this to be a separate patch as a future bisect could land inbetween this patch and the fix. Sorry for the extra work Arnd. thx, Jason.